work around g++ version 12, 13 and 14 spurious warning

[lmamane]

which is an error since we compile with -Werror

[github-actions]

Build size and comparison to main:

Section	Size	Difference
text	374512B	-16B
data	948B	0B
bss	63488B	0B

[mark9064]

An annoying g++ bug indeed

[TheGreatMcPain]

I ran into this one as well.

/home/myswamp/git-repos/pinetime/InfiniTime/src/displayapp/screens/Navigation.cpp:194:15: error: possibly dangling reference to a temporary [-Werror=dangling-reference]
  194 |   const auto& image = GetIcon("flag");
      |               ^~~~~

Had to add this.

diff --git a/src/displayapp/screens/Navigation.cpp b/src/displayapp/screens/Navigation.cpp
index ee9f2a00..01e14209 100644
--- a/src/displayapp/screens/Navigation.cpp
+++ b/src/displayapp/screens/Navigation.cpp
@@ -191,7 +191,10 @@ namespace {
  *
  */
 Navigation::Navigation(Pinetime::Controllers::NavigationService& nav) : navService(nav) {
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdangling-reference"
   const auto& image = GetIcon("flag");
+#pragma GCC diagnostic pop
   imgFlag = lv_img_create(lv_scr_act(), nullptr);
   lv_img_set_auto_size(imgFlag, false);
   lv_obj_set_size(imgFlag, 80, 80);

It's not exactly a "spurious warning", but it does happen in GCC14 for me.

[mark9064]

That one can be resolved by modernising the type of icon

-  Icon GetIcon(const std::string& icon) {
+  Icon GetIcon(std::string_view icon) {

Nonetheless it is a spurious warning (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114220)

[mark9064]

Also, the bounds warning bug disappears with LTO enabled. Intriguing