-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Multi face support, analog clock, 12/24 config #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for this high quality PR, @joaquimorg ! Apart from a few formatting details, I have only 1 point of attention : I can see 2 ways to improve this :
I'm not saying it should be done in this PR as it works fine right now, but that's definitely something we'll have to think about in the near future to be able to add other watchfaces that also needs graphical assets. I'll add some comments to fix the formatting issue and then we'll be able to fix the conflicts and merge :) |
|
Size really starts to be a problem, but we can only solve this when we are able to load this type of images from Flash. |
I think it should be possible to use RLE with LVGL using the image encoder API. The doc say that we can implement a decoder than provides images line-by-line to lvgl, which is exactly how the RLE decoder I use works. |
I hadn't thought about that option. |
Yes, that kind of features would be a better solution in the long term. Even with optimizations, we'll fill the whole internal memory one day or another :) So you're implementing your own file system instead of using a lib like littlefs? Is there a reason? Or is Littlefs using a lot of (RAM?) memory? Anyway, I'm interested in this feature, let us know when you have something to show us! In the mean time, I'll try to finish the review of this PR, sorry for the delay ! |
Changes made to this pull request: