BatteryInfo App Redesign #2236
BatteryInfo App Redesign #2236
Conversation
|
Build size and comparison to main:
|
… into battery_app_redesign
mark9064
added
enhancement
ljahn
left a comment
ljahn
left a comment
There was a problem hiding this comment.
Code looks good.
If one prefers the arc to a bar is personal preference.
|
Would love to see if this could find its way into main 😊 |
mark9064
left a comment
mark9064
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I prefer this design to the original, but it's totally up to taste. If anyone has a strong opinion against this one I'd be interested to hear it :)
… [...]' line in the Refresh() method
mark9064
left a comment
mark9064
left a comment
There was a problem hiding this comment.
LGTM! I'll queue it for 1.16 but let's leave some time before merging for other feedback
Great! Sounds like a good plan to me 😄 |
|
|
NeroBurner
left a comment
NeroBurner
left a comment
There was a problem hiding this comment.
code looks good, UI as well
Redesign BatteryInfo App using an Arch widget instead of a bar. The colors I used are as follows: - Discharging (default): green - Charging: lime - Battery full: blue - Battery low (<10%): red
4 participants
This PR is a redesign of the BatteryInfo app.
The colors I used are as follows:
Discharging (default): green
Charging: lime
Battery full: blue
Battery low (<10%): red
Here's a pic of it in InfiniEmu, as well as how each state looks like on-device.
(Can't manage to rescale this image on iOS, I'll get to it later)