Skip to content

Conversation

@tituscmd
Copy link
Contributor

This PR adds a background color to the progress bar when updating firmware.
It also removes the space between the value and the "%", since I feel like that's more commonly used and, in my opinion, looks better. Feel free to give your opinion on that, though!

Here's a pic of how it looks like on device:
(Hint: To see it in action, you’ll first need to flash the firmware. Then, flash any other firmware, as the firmware update screen is displayed by the firmware currently on the device.)
progress_bar

@github-actions
Copy link

github-actions bot commented Jan 27, 2025

Build size and comparison to main:

Section Size Difference
text 375828B 48B
data 948B 0B
bss 22536B 0B

Run in InfiniEmu

@mark9064 mark9064 added enhancement Enhancement to an existing app/feature UI/UX User interface/User experience labels Feb 7, 2025
Copy link
Member

@mark9064 mark9064 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested on HW, but looks good from the screenshot :)

@mark9064 mark9064 added this to the 1.16.0 milestone Feb 14, 2025
@Saarsk
Copy link

Saarsk commented Mar 27, 2025

Just a note about the space between the value and percentage sign. A space there is the correct way of writing it. 🙂 I think it should be formatted the correct way.

I can understand that sometimes it happens that the correct way doesn't feel right. We tend to expect what we're conditioned to. I've had the same experience.

Though, it's just a matter of getting used to it, i.e. reconditioning. So rather than doing what subjectively feels right I think there's value to following objectively correct and commonly agreed conventions. 🙂 A lack there of will have negative effects regardless whether it's in a software project or in a book, as we adopt by reading and using language. So whenever something is incorrect, it spreads.

Other than that, I very much welcome the progress bar improvement. 😊

@tituscmd
Copy link
Contributor Author

"However, the International System of Units and ISO 31-0 standard prescribe a space between the number and percent sign,[8][9][10] in line with the general practice of using a non-breaking space between a numerical value and its corresponding unit of measurement."

Let's go for this then, shall we?

@mark9064
Copy link
Member

I think without the space is better. Wikipedia is quite clear: English style guides prescribe writing the percent sign following the number without any space between (e.g. 50%)

InfiniTime is not a technical document, but instead a user interface. Therefore I think following general English style and precedent makes sense. If it were a technical report then I would agree that recognising a standard such as ISO would be sensible (and if I were typsetting with LateX I would by using siunitx), and the same may apply in another language (it appears that some languages expect a space by default)

@minacode
Copy link
Contributor

Can't test it right now but would approve it from reading the code and seeing the images. Tell me if you would be ok with this, then I can accept it as well.

@tituscmd
Copy link
Contributor Author

tituscmd commented May 14, 2025

I think from my side this PR should be done as well.

@mark9064 mark9064 merged commit 85be83b into InfiniTimeOrg:main May 15, 2025
7 checks passed
JustScott pushed a commit to JustScott/InfiniTime that referenced this pull request Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement to an existing app/feature UI/UX User interface/User experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants