-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
navigation: fix greying out the app icon if not enabled #2301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Build size and comparison to main:
|
08abd5e to
f2f5ec3
Compare
|
Fixing it for just one App feels wrong for me. Would you be interested in implementing the same behavior as done with the Watchfaces? Having a default |
|
@NeroBurner sure, I can do that :-) . I stumbled upon that thing while doing the other navigation stuff and InfiniSim not showing the flags, but also did not have a grasp on how the whole thing works. So you're definitly right, doing that only for Navigation does not scale :-) and also thanks for pointing out how things should look correctly. |
f2f5ec3 to
915a9bd
Compare
|
Hopefully that is what you had in mind :-) ... Follows now how the Wachfaces look |
NeroBurner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you got it right. Good job!
mark9064
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the PR :)
915a9bd to
7e0b63a
Compare
Commit 0aead42 ("navigation: Add is available (InfiniTimeOrg#1847)") added the ability to draw the app icon in grey and in a disabled state when some prerequisits were not met. Only the Navigation app was using this mechanism due to its icons being stored in the external memory and possibly missing. Commit 63e0c4f ("Application selection at build time") broke this by always setting the state as true: for (const auto& userApp : userApps) { apps[i++] = Screens::Tile::Applications {userApp.icon, userApp.app, true}; } Fix this by creating an isAvailable() strcuture in the app classes, similar to how the Watchfaces handle the same problem of checking availability.
7e0b63a to
b6c20f6
Compare
Commit 0aead42 ("navigation: Add is available (#1847)") added the ability to draw the app icon in grey and in a disabled state when some prerequisits were not met. Only the Navigation app was using this mechanism due to its icons being stored in the external memory and possibly missing.
Commit 63e0c4f ("Application selection at build time") broke this by always setting the state as true:
for (const auto& userApp : userApps) {
apps[i++] = Screens::Tile::Applications {userApp.icon, userApp.app, true};
}
Fix this by creating an isAvailable() strcuture in the app classes, similar
to how the Watchfaces handle the same problem of checking availability.