Touchscreen timeout fix #2325
Merged
Touchscreen timeout fix #2325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build size and comparison to main:
|
NeroBurner
reviewed
Jun 28, 2025
NeroBurner
reviewed
Jun 28, 2025
mark9064
force-pushed
the
touchscreen-timeout
branch
from
5a18a02 to
7637336
Compare
NeroBurner
reviewed
Jun 28, 2025
mark9064
force-pushed
the
touchscreen-timeout
branch
from
7637336 to
d195d8d
Compare
Contributor
|
can you separate the only read what we need part into its own PR we can approve and merge first. Then each PR does (or fix) exactly one thing (and ping me in the new PR so I can approve :) |
Member
Author
|
if it's useful it's already two commits, but i can definitely split out if youd prefer |
mark9064
force-pushed
the
touchscreen-timeout
branch
from
d195d8d to
a62ec43
Compare
Member
Author
|
Opened #2349 for the touchpanel reading refactor |
NeroBurner
approved these changes
Oct 14, 2025
Contributor
NeroBurner
left a comment
NeroBurner
left a comment
There was a problem hiding this comment.
change looks minimal. I assume you have this feature running for some time on your pinetime. Then I'd say LGTM
Member
Author
|
Yep, has been working great locally. A friend has confirmed it fixed jumps in paddle for them too, so I think it's good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #2189
Closes #1143
Still have no clue why github deleted the original issue??