Analog face constexpr fix #2327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build size and comparison to main:
|
NeroBurner
approved these changes
Jun 27, 2025
mark9064
force-pushed
the
analog-constexpr
branch
from
907f23f to
59a3f08
Compare
Member
Author
|
Just realised I wasn't using |
NeroBurner
approved these changes
Jun 28, 2025
Contributor
NeroBurner
left a comment
NeroBurner
left a comment
There was a problem hiding this comment.
maybe my non-native-english and programmer view, but yes sin and cos are more familiar for me 😁
mark9064
force-pushed
the
analog-constexpr
branch
from
59a3f08 to
efa04a4
Compare
Member
Author
|
Spotted a typo and clarified why it can't be constexpr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.