Replace app_timer with FreeRTOS timers in TimerController#494
Merged
Riksu9000 merged 1 commit intoInfiniTimeOrg:developfrom Apr 25, 2022
Riksu9000:remove_app_timer
Merged
Replace app_timer with FreeRTOS timers in TimerController#494Riksu9000 merged 1 commit intoInfiniTimeOrg:developfrom Riksu9000:remove_app_timer
Riksu9000 merged 1 commit intoInfiniTimeOrg:developfrom
Riksu9000:remove_app_timer
Conversation
Contributor
Author
|
After #544, converting MotorController to use FreeRTOS Timers would require more work, so I removed the changes for now. For now only TimerController is converted. |
Riksu9000
changed the title
Merged
Contributor
Author
|
@NeroBurner The simulator doesn't have these two functions |
Contributor
|
@Riksu9000 thanks for the notification, please try with the current |
NeroBurner
approved these changes
Mar 29, 2022
JF002
reviewed
Apr 24, 2022
JF002
approved these changes
Apr 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I read that this would be preferred, as app_timer is an nrf specific feature.