Conversation
Fix glob pattern Fix missing submodule code
| - name: Install Embedded Arm Toolchain arm-none-eabi-gcc | ||
| if: steps.cache-toolchain.outputs.cache-hit != 'true' # Install toolchain if not found in cache | ||
| uses: fiam/arm-none-eabi-gcc@v1.0.2 | ||
| uses: fiam/arm-none-eabi-gcc@v1.0.4 |
There was a problem hiding this comment.
This fixes this error in the build:
| run: | | ||
| cd ${{ runner.temp }} | ||
| git clone --branch v1.5.0 https://github.com/JuulLabs-OSS/mcuboot | ||
| git clone --branch v1.7.2 https://github.com/JuulLabs-OSS/mcuboot |
| with: | ||
| submodules: 'true' |
There was a problem hiding this comment.
This fixes the following:
(missing submodules)
| # The generated firmware binary looks like "pinetime-mcuboot-app-0.8.2.bin" | ||
| ls -l build/src/pinetime-mcuboot-app*.bin | ||
| ${{ runner.temp }}/mcuboot/scripts/imgtool.py create --align 4 --version 1.0.0 --header-size 32 --slot-size 475136 --pad-header build/src/pinetime-mcuboot-app*.bin build/src/pinetime-mcuboot-app-img.bin | ||
| ${{ runner.temp }}/mcuboot/scripts/imgtool.py create --align 4 --version 1.0.0 --header-size 32 --slot-size 475136 --pad-header build/src/pinetime-mcuboot-app-[0-9]*.bin build/src/pinetime-mcuboot-app-img.bin |
There was a problem hiding this comment.
This fixes:
The new glob pattern excludes pinetime-mcuboot-app-image-1.3.0.bin so there is only one input file to pass to the create command.
|
Thanks for this PR! |
Yes, I'll propose my changes in #333 then. |
2 participants
I just got my PineTime dev kit and wanted to experiment with custom firmware. I wanted to take advantage of the GitHub workflow to build, but it seems broken on
master.This PR is fixing all the issues.
I tested the output file
pinetime-mcuboot-app-dfu.zipwith OTA firmware update with my dev kit.