Skip to content

Make new notifications refresh idle timer#652

Merged
JF002 merged 1 commit intoInfiniTimeOrg:developfrom
dyamon:wake-on-notification
Oct 16, 2021
Merged

Make new notifications refresh idle timer#652
JF002 merged 1 commit intoInfiniTimeOrg:developfrom
dyamon:wake-on-notification

Conversation

@dyamon
Copy link
Contributor

@dyamon dyamon commented Sep 7, 2021

Refresh idle timer if the screen is on and the PineTime receives a new notification.

evergreen22 added a commit to evergreen22/InfiniTime that referenced this pull request Sep 9, 2021
Copy link
Contributor

@evergreen22 evergreen22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on dev-kit and daily driver - no regressions and works as expected.

Thanks.

@Avamander
Copy link
Collaborator

Please fix the conflicts.

@dyamon
Copy link
Contributor Author

dyamon commented Oct 13, 2021

Sure I'll rebase the file asap.

@geekbozu
Copy link
Member

geekbozu commented Oct 13, 2021

I have tested this extensively on my end works great. Conflicts are "simple"

    case Messages::OnNewNotification:
          if (settingsController.GetNotificationStatus() == Pinetime::Controllers::Settings::Notification::ON) {
            if (isSleeping && !isWakingUp) {
              GoToRunning();
            } else {
              ReloadIdleTimer();
            }
            displayApp.PushMessage(Pinetime::Applications::Display::Messages::NewNotification);
          }
          break;

dont do a me and put the break inside the if statement however...that breaks things :P

@dyamon dyamon force-pushed the wake-on-notification branch from 8c4959d to 59ce48a Compare October 14, 2021 20:21
@dyamon
Copy link
Contributor Author

dyamon commented Oct 14, 2021

Rebased resolving conflicts as suggested by @geekbozu

Copy link
Member

@geekbozu geekbozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I've been running this for like a week, Does what it says on the tin.

@JF002
Copy link
Collaborator

JF002 commented Oct 16, 2021

Thanks!

@JF002 JF002 added this to the 1.7.0 milestone Oct 16, 2021
@JF002 JF002 merged commit 8165c86 into InfiniTimeOrg:develop Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants