Make new notifications refresh idle timer#652
Merged
JF002 merged 1 commit intoInfiniTimeOrg:developfrom Oct 16, 2021
Merged
Conversation
evergreen22
added a commit
to evergreen22/InfiniTime
that referenced
this pull request
Sep 9, 2021
evergreen22
approved these changes
Sep 9, 2021
Contributor
evergreen22
left a comment
There was a problem hiding this comment.
Tested on dev-kit and daily driver - no regressions and works as expected.
Thanks.
Collaborator
|
Please fix the conflicts. |
Contributor
Author
|
Sure I'll rebase the file asap. |
Member
|
I have tested this extensively on my end works great. Conflicts are "simple" case Messages::OnNewNotification:
if (settingsController.GetNotificationStatus() == Pinetime::Controllers::Settings::Notification::ON) {
if (isSleeping && !isWakingUp) {
GoToRunning();
} else {
ReloadIdleTimer();
}
displayApp.PushMessage(Pinetime::Applications::Display::Messages::NewNotification);
}
break;dont do a me and put the break inside the if statement however...that breaks things :P |
geekbozu
approved these changes
Oct 13, 2021
8c4959d to
59ce48a
Compare
Contributor
Author
|
Rebased resolving conflicts as suggested by @geekbozu |
geekbozu
approved these changes
Oct 15, 2021
Member
geekbozu
left a comment
There was a problem hiding this comment.
Looks great! I've been running this for like a week, Does what it says on the tin.
Collaborator
|
Thanks! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refresh idle timer if the screen is on and the PineTime receives a new notification.