Skip to content

Fix recovery firmware build#791

Merged
JF002 merged 1 commit intoInfiniTimeOrg:developfrom
evergreen22:recovery-boot
Oct 31, 2021
Merged

Fix recovery firmware build#791
JF002 merged 1 commit intoInfiniTimeOrg:developfrom
evergreen22:recovery-boot

Conversation

@evergreen22
Copy link
Contributor

@evergreen22 evergreen22 commented Oct 29, 2021

Fix the "recovery" firmware build targets

Error introduced in #746

@evergreen22 evergreen22 reopened this Oct 29, 2021
@JF002
Copy link
Collaborator

JF002 commented Oct 30, 2021

@evergreen22 Why did you reopen this PR? The last build on develop succeeded.

@evergreen22
Copy link
Contributor Author

I reopened because building recovery targets didn't work for me. The compiler looked in the systems folders for the BootErrors.h file instead of locally. The CI build works, but I don't think it is building any of the recovery targets.

@evergreen22
Copy link
Contributor Author

I can see that the recovery target is building on CI (wasn't logged in to GH when I replied before). All I can say is that the recovery targets will not build on my local machine unless the change in this PR is made.

@JF002
Copy link
Collaborator

JF002 commented Oct 31, 2021

Ok, I got confused by the new colors in Github. I thought you re-open PR that was already merged...
I had a look at the changes, and they make sense, I'll merge it ;)
I'm not sure why it works on github/docker/my setup and not on your side, though.

@JF002 JF002 added this to the 1.7.0 milestone Oct 31, 2021
@JF002 JF002 merged commit 0aa73c2 into InfiniTimeOrg:develop Oct 31, 2021
@evergreen22 evergreen22 deleted the recovery-boot branch November 4, 2021 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants