Fix Alarm app crashing on buttonpress

[Riksu9000]

Fixes #770

This should be fixed before releasing 1.7.0

[mruss77]

Thanks, I came in here to open this same PR this morning!

I've been testing the same fix for several days and the alarm is no longer crashing.

[Avamander]

Why not initialize them all to nullptr?

[Riksu9000]

Why not initialize them all to nullptr?

Everything else gets initialized in the constructor and we don't initialize them to nullptr in other screens either.

[Avamander]

Everything else gets initialized in the constructor and we don't initialize them to nullptr in other screens either.

Do you have any ideas how such uninitialized variables could be better avoided? Any warnings?

[Riksu9000]

Everything else gets initialized in the constructor and we don't initialize them to nullptr in other screens either.

Do you have any ideas how such uninitialized variables could be better avoided? Any warnings?

There was a warning that the constructor doesn't initialize those variables.

[Avamander]

There was a warning that the constructor doesn't initialize those variables.

What was the name? Maybe it should be turned into an error with -Werror=<name>.

[Riksu9000]

There was a warning that the constructor doesn't initialize those variables.

What was the name? Maybe it should be turned into an error with -Werror=<name>.

Oh not a compilation warning but a clang-tidy one. This one https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines-pro-type-member-init.html

[ncartron]

Hi, I had a pre 1.7 DFU without this PR and the Alarm app was constantly crashing.
I confirm that with a DFU which includes that PR, the Alarm app works as expected, no more crash ! <3

[petterhs]

PR is fixing the issue 👍

[JF002]

Thanks! Just in time for 1.7! (Initially, I was going to release it sooner, but I was too busy these last few days...).