Skip to content

PineTimeStyle: move down notification icon away from bluetooth icon#858

Closed
NeroBurner wants to merge 1 commit intoInfiniTimeOrg:developfrom
NeroBurner:pinetimestyle_notification_icon_down
Closed

PineTimeStyle: move down notification icon away from bluetooth icon#858
NeroBurner wants to merge 1 commit intoInfiniTimeOrg:developfrom
NeroBurner:pinetimestyle_notification_icon_down

Conversation

@NeroBurner
Copy link
Contributor

@NeroBurner NeroBurner commented Dec 2, 2021

The notification icon and the bluetooth icon overlapped. Move the Notification icon down a bit for better alignment.

up until now the PineTimeStyle looks like this:

20211202_PineTimeStyle

With the new notification placement it looks as follows (edit: now pixel perfect)

  • Battery - 7px - bluetooth - 7px - notification - 8px - FRI
  • Charger - 4px - bluetooth - 7px - notification - 8px - FRI

2021-12-03 battery 7px 7px 8px 2021-12-03 charge 4px 7px 8px

edit old pictures of first try:

20211202_PineTimeStyle with fixed notification charging 20211202_PineTimeStyle with fixed notification on battery

@NeroBurner NeroBurner marked this pull request as draft December 3, 2021 07:24
@NeroBurner
Copy link
Contributor Author

I'll move the i a few more pixel further down, to have the alignment in the battery-case matching better. The daily-driver is on battery, not on charging, so I'll make it fit the battery usecase as perfect as possible

The notification icon and the bluetooth icon overlapped. Move the
Notivication icon down a bit for better alignment.

Pixel perfect placement:
- Battery - 7px - bluetooth - 7px - notification - 8px - FRI
- Charger - 4px - bluetooth - 7px - notification - 8px - FRI
@NeroBurner NeroBurner force-pushed the pinetimestyle_notification_icon_down branch from 74c637e to d6ad7be Compare December 3, 2021 16:49
@NeroBurner
Copy link
Contributor Author

Now pixel perfect placement

  • Battery - 7px - bluetooth - 7px - notification - 8px - FRI
  • Charger - 4px - bluetooth - 7px - notification - 8px - FRI

2021-12-03 battery 7px 7px 8px 2021-12-03 charge 4px 7px 8px

@NeroBurner NeroBurner marked this pull request as ready for review December 3, 2021 16:49
@kieranc
Copy link
Contributor

kieranc commented Dec 6, 2021

This fix is included in #718 but I have a better solution which places the icons side by side below the battery icon, and realigns them depending on how many icons are visible. I'll push it shortly...

edit: #869

@NeroBurner
Copy link
Contributor Author

closed in favor of #869

@NeroBurner NeroBurner closed this Dec 7, 2021
@NeroBurner NeroBurner deleted the pinetimestyle_notification_icon_down branch March 7, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants