Hrs driver changes #876
Merged
Hrs driver changes #876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riksu9000
approved these changes
Jan 5, 2022
Contributor
Riksu9000
left a comment
Riksu9000
left a comment
There was a problem hiding this comment.
The resolution is limited to 16 bits, which is why this hasn't been an issue, but it should be fixed so there won't be any issues in the future.
Collaborator
|
@yehoshuapw Thanks, and congratulations for your first contribution to the project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed low level driver for HRS3300 to return uint32_t values (since it gives 18 bit values)
and changed hidden uint16_t to float convert, to a static_cast.
supersedes #875
thanks for all the great work!