Skip to content

Implement showermode#894

Closed
gnome71 wants to merge 5 commits intoInfiniTimeOrg:developfrom
gnome71:implement-showermode
Closed

Implement showermode#894
gnome71 wants to merge 5 commits intoInfiniTimeOrg:developfrom
gnome71:implement-showermode

Conversation

@gnome71
Copy link

@gnome71 gnome71 commented Dec 30, 2021

This pull request adds a "showermode". It can be enabled by a long tap on the Analog- or DigitalWatchFace. It basically just saves the current WakeUpMode and then disables it. The watch will then not be woken up by contact with water - hence "showermode". To disable the showermode, wake up the watch by ButtonPress and LongTap again on Analog- or DigitalWatchFace. If the showermode is active, is shown by an icon on these WatchFaces.

What's not implemented yet, is to send the watch to sleep 5 seconds after activating the showermode to not have to wait for whatever ScreenTimeout is set.

@geekbozu
Copy link
Member

geekbozu commented Jan 1, 2022

I like the Idea of this. However I'm not sure we want to actually recommend the PT go in the shower....depending on the glue work I have seen a few units fail due to water ingress...they really are only splash proof.

Good work either way!

@Itai-Nelken
Copy link
Contributor

This probably conflicts with the PTS settings that alsonuses the long press since #718

@gnome71
Copy link
Author

gnome71 commented Jan 2, 2022

Thanks for your reply. At least I learned a lot about InfiniTime and the Git workflow. Keep up your good work!!

@Riksu9000 Riksu9000 added the needs more work This PR needs more work label Jan 21, 2022
@trman
Copy link

trman commented Feb 21, 2022

feature need to be reworked @gnome71 , and name of functionality changed to no longer talk about putting pinetime inside water like requirement of @Riksu9000 in #961

@Riksu9000
Copy link
Contributor

There's a simpler way to do this #961. I'm also assuming this isn't something that we'll be adding.

@Riksu9000 Riksu9000 closed this Mar 24, 2022
@shvechkov
Copy link

shvechkov commented Apr 3, 2022

There's a simpler way to do this #961. I'm also assuming this isn't something that we'll be adding.

When exercising long (sweaty) sleeves touch the screen and mess all the settings on my PT ... Locking screen is MUST HAVE feature for folks who wear PT in the gym ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs more work This PR needs more work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants