[Maze] Better handle initial starts and ignore other VarbitChanged#40
Merged
[Maze] Better handle initial starts and ignore other VarbitChanged#40
Conversation
- Added proper support for handling initial runs when (re)starting the plugin when already inside the maze random event
- Now ignoring VarbitChanged events for Drill demon and Pirate Chest when fired from within the maze random event - Added a maze instance check to the Drill Demon random event for VarbitChanged - Added a maze instance check to the Pirate Chest random revent for VarbitChanged
- Added proper support for handling initial runs when (re)starting the plugin when already inside the Maze random event - Fixed unnecessary VarbitChanged event handling when fired from within the Maze random event
Owner
Author
chore: Update plugin to v2.6.2
|
Infinitay
added
implemented
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(maze): Add support for starting in event
fix(maze): Fix handling varbit changed events for other events
Regarding the VarbitChanged changes, when inside the random event maze, the game modifies varbits associated with the drill demon and pirate chest random events. Not sure why this happens, but I'll early-return out of the event handling to avoid extra logging.