Skip to content

styling fixes, add links to new resources page#125

Merged
InfinityBowman merged 1 commit into
mainfrom
122-resources-page
Dec 21, 2025
Merged

styling fixes, add links to new resources page#125
InfinityBowman merged 1 commit into
mainfrom
122-resources-page

Conversation

@InfinityBowman
Copy link
Copy Markdown
Owner

@InfinityBowman InfinityBowman commented Dec 21, 2025

Summary by CodeRabbit

  • New Features

    • Tools in Supported Tools section are now clickable and link to resources with interactive hover effects.
  • Style

    • Added visible borders to navbar buttons in desktop and mobile menus.
    • Enhanced tool cards with hover states and visual feedback.

✏️ Tip: You can customize this high-level summary in your review settings.

@InfinityBowman InfinityBowman merged commit 5fd88b0 into main Dec 21, 2025
2 of 3 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Dec 21, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

These changes consolidate URL management by replacing hardcoded AMSTAR 2 links with a dynamic LANDING_URL configuration, updating the Navbar with border styling, reordering the SupportedTools array, and making tool cards linkable to the centralized /resources endpoint while retaining non-interactive styling for coming-soon items.

Changes

Cohort / File(s) Summary
Landing UI styling and interactions
packages/landing/src/components/Navbar.jsx, packages/landing/src/components/SupportedTools.jsx
Updated Navbar anchor elements with border styling. Restructured SupportedTools rendering to conditionally render clickable anchors (linking to /resources) for available tools or non-clickable divs for coming-soon items. Reordered Cochrane RoB 2 in tools array.
URL configuration centralization
packages/web/src/config/api.js, packages/web/src/checklist-registry/types.js
Removed hardcoded AMSTAR2_URL constant from api.js. Updated AMSTAR 2 checklist metadata to use dynamic URL built from LANDING_URL + '/resources' path.
URL resolution dependency update
packages/web/src/components/checklist-ui/ScoreTag.jsx
Removed AMSTAR2_URL import and changed getInfoUrl to return metadata.url exclusively, eliminating the fallback to a hardcoded constant.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • SupportedTools.jsx: Review the conditional rendering logic (anchor vs. div wrapper) and ensure the /resources link behavior is correct for both available and coming-soon states.
  • URL migration consistency: Verify that all hardcoded URL references have been properly migrated to LANDING_URL-based configuration, particularly ScoreTag.jsx's removal of the AMSTAR2_URL fallback to ensure no undefined URL scenarios.
  • Cross-package integration: Confirm the metadata.url dependency chain works correctly between checklist-registry/types.js and ScoreTag.jsx.

Possibly related PRs

  • 122 resources page #123: Adds the /resources page, routes, sitemap entry, and footer link that these changes now point to, making this PR dependent on that one.
  • 49 feedback and support #57: Also modifies packages/landing/src/components/Navbar.jsx, which may result in merge conflicts.

Poem

🐰 Our tools now dance in harmony,
All roads lead to /resources' door—
No hardcoded chains to set us free,
Just LANDING_URL, clean and pure! 🗂️
Links bloom where once they slept before.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 122-resources-page

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 714e947 and 2319a38.

📒 Files selected for processing (5)
  • packages/landing/src/components/Navbar.jsx (4 hunks)
  • packages/landing/src/components/SupportedTools.jsx (3 hunks)
  • packages/web/src/checklist-registry/types.js (2 hunks)
  • packages/web/src/components/checklist-ui/ScoreTag.jsx (1 hunks)
  • packages/web/src/config/api.js (0 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@InfinityBowman InfinityBowman deleted the 122-resources-page branch December 21, 2025 17:34
@coderabbitai coderabbitai Bot mentioned this pull request Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant