161 labeling and wording improvements#162
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
corates | 872ed98 | Commit Preview URL | Dec 26 2025, 03:59 PM |
📝 WalkthroughWalkthroughTwo components updated: ProjectView adds count badge helpers for "All Studies" and "Completed" tabs. OverviewTab refactors progress tracking from per-study to per-user (reviewer-based), updates section labels and layout, removes "In Progress" metric, and adds new "Tables" collapsible section. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/web/src/components/project-ui/overview-tab/OverviewTab.jsx (1)
41-49: Consider usingcreateMemofor derived values.
readyToReconcileandcompletedStudiesare derived from reactive state (studies()) and are used in JSX. Per coding guidelines, usecreateMemofor derived values to ensure they update reactively and avoid redundant recalculations.Proposed fix
- const readyToReconcile = () => - studies().filter(s => { + const readyToReconcile = createMemo(() => + studies().filter(s => { const checklists = s.checklists || []; const completedChecklists = checklists.filter(c => c.status === CHECKLIST_STATUS.COMPLETED); return completedChecklists.length === 2; - }).length; + }).length + ); - const completedStudies = () => - studies().filter(s => shouldShowInTab(s, 'completed', null)).length; + const completedStudies = createMemo(() => + studies().filter(s => shouldShowInTab(s, 'completed', null)).length + );
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/web/src/components/project-ui/ProjectView.jsxpackages/web/src/components/project-ui/overview-tab/OverviewTab.jsx
🧰 Additional context used
📓 Path-based instructions (14)
**/*
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Do not use emojis in code, comments, documentation, or commit messages
NEVER use emojis anywhere in code, comments, documentation, plan files, or commit messages. This includes unicode symbols. For UI icons, use solid-icons library or SVGs only.
Files:
packages/web/src/components/project-ui/ProjectView.jsxpackages/web/src/components/project-ui/overview-tab/OverviewTab.jsx
packages/web/src/**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
packages/web/src/**/*.{js,jsx,ts,tsx}: For UI icons, use thesolid-iconslibrary or SVGs only. Do not use emojis
Ensure browser compatibility for all frontend code (Safari is usually problematic)
Keep files small, focused, and modular. If a file exceeds a high number of lines, consider refactoring by extracting sub-modules into a folder with index.jsx and helper components, moving complex logic into separate utility files or primitives, or splitting large forms into section components
Do NOT prop-drill application state. Shared or cross-feature state must live in external stores under packages/web/src/stores/ or relative to the component file
UsecreateMemofor derived values to ensure they update reactivelyUse import aliases from jsconfig.json instead of relative paths
Files:
packages/web/src/components/project-ui/ProjectView.jsxpackages/web/src/components/project-ui/overview-tab/OverviewTab.jsx
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{js,jsx,ts,tsx}: Prefer modern ES6+ syntax and features
Use aliases for imports when appropriate to improve readability
**/*.{js,jsx,ts,tsx}: Prefer modern ES6+ syntax and features in JavaScript/TypeScript code
Comments should explain why something is being done, not narrate what the code does. Avoid comments that repeat variable names or describe obvious code behavior.
Files:
packages/web/src/components/project-ui/ProjectView.jsxpackages/web/src/components/project-ui/overview-tab/OverviewTab.jsx
packages/web/src/components/**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
packages/web/src/components/**/*.{js,jsx,ts,tsx}: Use responsive design principles for UI components
Group related components in subdirectories with an index.js barrel export
Use Zag.js for UI components and design system
Zag component exist inpackages/web/src/components/zag/*and should be reused. Check the README.md in that folder for a list of existing components before adding new components and when debugging
Components should receive at most 1–5 props, and only for local configuration, not shared state. If a component would need more than 5 props, move the shared data into an external store, a primitive, or Solid context
Do not destructure props in SolidJS components as it breaks reactivity. Instead, access props directly from the props object or wrap them in a function to ensure they are always up-to-date
Components should be lean and focused. They should not implement business logic; move that into stores, utilities, or primitives
Never have a component act as a God component coordinating multiple large concerns
Files:
packages/web/src/components/project-ui/ProjectView.jsxpackages/web/src/components/project-ui/overview-tab/OverviewTab.jsx
packages/{web,ui}/src/**/*.{jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/corates.mdc)
Group related components in subdirectories with barrel exports
Files:
packages/web/src/components/project-ui/ProjectView.jsxpackages/web/src/components/project-ui/overview-tab/OverviewTab.jsx
packages/{web,landing}/src/**/*.{jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/corates.mdc)
packages/{web,landing}/src/**/*.{jsx,tsx}: Use Ark UI components from @corates/ui package, not local component implementations
Use solid-icons library (e.g., solid-icons/bi, solid-icons/fi) for icon imports
Files:
packages/web/src/components/project-ui/ProjectView.jsxpackages/web/src/components/project-ui/overview-tab/OverviewTab.jsx
packages/web/src/**/*.{jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/corates.mdc)
packages/web/src/**/*.{jsx,tsx}: In SolidJS, do NOT prop-drill application state. Import stores directly where needed instead.
In SolidJS, do NOT destructure props. Access props.field directly or wrap in a function: () => props.field
In SolidJS components, components should receive at most 1-5 props (local config only, not shared state)
Files:
packages/web/src/components/project-ui/ProjectView.jsxpackages/web/src/components/project-ui/overview-tab/OverviewTab.jsx
packages/web/src/**/*.{jsx,tsx,js,ts}
📄 CodeRabbit inference engine (.cursor/rules/corates.mdc)
In SolidJS, use createMemo for derived values
Files:
packages/web/src/components/project-ui/ProjectView.jsxpackages/web/src/components/project-ui/overview-tab/OverviewTab.jsx
packages/web/src/**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/error-handling.mdc)
packages/web/src/**/*.{js,ts,jsx,tsx}: Always usehandleFetchErrorfrom@/lib/error-utils.jsfor fetch calls in frontend code with options like{ showToast: true }for error handling
UsecreateFormErrorSignalsfrom@/lib/form-errors.jsfor form validation error handling with field-level and global error management
Files:
packages/web/src/components/project-ui/ProjectView.jsxpackages/web/src/components/project-ui/overview-tab/OverviewTab.jsx
packages/{web,workers}/src/**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/error-handling.mdc)
packages/{web,workers}/src/**/*.{js,ts,jsx,tsx}: Never throw string literals; always throw Error objects or return domain errors from API routes
Use error utility functions likeisErrorCodefrom@corates/sharedor@/lib/error-utils.jsto check specific error types instead of manual string comparisons
Files:
packages/web/src/components/project-ui/ProjectView.jsxpackages/web/src/components/project-ui/overview-tab/OverviewTab.jsx
{packages/web/**,packages/landing/**}/**/*.{jsx,tsx,js,ts}
📄 CodeRabbit inference engine (.cursor/rules/solidjs.mdc)
{packages/web/**,packages/landing/**}/**/*.{jsx,tsx,js,ts}: Never destructure props in SolidJS components - destructuring breaks reactivity. Access props directly (e.g.,props.name) or wrap in a function (e.g.,const name = () => props.name) to maintain reactivity.
Import stores directly in components rather than prop-drilling store data through component hierarchies.
Use separate read and write patterns for stores: import the store directly for reading data (e.g.,projectStore.getProjectList()) and import action stores separately for writing (e.g.,projectActionsStore.createProject()).
UsecreateSignalfrom solid-js for managing simple reactive values. Prefer derived state with signals or memo over effects when possible.
UsecreateStorefrom solid-js/store for managing complex objects and arrays that require granular reactivity, enabling fine-grained updates where only affected parts re-render.
UsecreateMemofrom solid-js for derived values that depend on reactive state, ensuring computed values update only when their dependencies change.
Always clean up effects that create subscriptions or timers using theonCleanupfunction from solid-js. Use effects sparingly, only when derived values won't work well.
Keep components lean and focused on rendering. Move business logic to stores (for shared state and operations), primitives (for reusable hooks/logic), or utilities (for pure functions).
Use theShowcomponent from solid-js for conditional rendering instead of JavaScript ternary operators or logical AND operators.
Use theForcomponent from solid-js for rendering lists. It provides better performance and keying compared to JavaScript's map function in JSX.
When manipulating children in wrapper components, use thechildrenhelper from solid-js to ensure proper reactivity and handling of child elements.
Files:
packages/web/src/components/project-ui/ProjectView.jsxpackages/web/src/components/project-ui/overview-tab/OverviewTab.jsx
packages/{web,ui}/**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ui-components.mdc)
packages/{web,ui}/**/*.{js,jsx,ts,tsx}: Import UI components from '@corates/ui' package instead of local component files. Do not import Ark UI components from local paths like '@/components/zag/' or 'packages/web/src/components/zag/'
Always use 'solid-icons' library for icons. Never use emoji characters or text as icon replacements. Import from specific icon sets like 'solid-icons/bi', 'solid-icons/fi', 'solid-icons/ai', etc.
Files:
packages/web/src/components/project-ui/ProjectView.jsxpackages/web/src/components/project-ui/overview-tab/OverviewTab.jsx
packages/web/**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ui-components.mdc)
Use import aliases from 'packages/web/jsconfig.json' instead of relative paths. Aliases include: '@/' (src/), '@components/' (src/components/), '@auth-ui/' (src/components/auth-ui/), '@checklist-ui/' (src/components/checklist-ui/), '@project-ui/' (src/components/project-ui/), '@routes/' (src/routes/), '@primitives/' (src/primitives/), '@api/' (src/api/), '@config/' (src/config/), and '@lib/' (src/lib/)
Files:
packages/web/src/components/project-ui/ProjectView.jsxpackages/web/src/components/project-ui/overview-tab/OverviewTab.jsx
packages/{web,ui}/**/*.{jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/ui-components.mdc)
Use Tailwind CSS classes for styling components
Files:
packages/web/src/components/project-ui/ProjectView.jsxpackages/web/src/components/project-ui/overview-tab/OverviewTab.jsx
🧠 Learnings (5)
📚 Learning: 2025-12-24T17:22:48.927Z
Learnt from: CR
Repo: InfinityBowman/corates PR: 0
File: .cursor/rules/corates.mdc:0-0
Timestamp: 2025-12-24T17:22:48.927Z
Learning: Applies to packages/{web,landing}/src/**/*.{jsx,tsx} : Use solid-icons library (e.g., solid-icons/bi, solid-icons/fi) for icon imports
Applied to files:
packages/web/src/components/project-ui/overview-tab/OverviewTab.jsx
📚 Learning: 2025-12-24T17:23:17.309Z
Learnt from: CR
Repo: InfinityBowman/corates PR: 0
File: .cursor/rules/ui-components.mdc:0-0
Timestamp: 2025-12-24T17:23:17.309Z
Learning: Applies to packages/{web,ui}/**/*.{js,jsx,ts,tsx} : Always use 'solid-icons' library for icons. Never use emoji characters or text as icon replacements. Import from specific icon sets like 'solid-icons/bi', 'solid-icons/fi', 'solid-icons/ai', etc.
Applied to files:
packages/web/src/components/project-ui/overview-tab/OverviewTab.jsx
📚 Learning: 2025-12-24T17:23:10.082Z
Learnt from: CR
Repo: InfinityBowman/corates PR: 0
File: .cursor/rules/solidjs.mdc:0-0
Timestamp: 2025-12-24T17:23:10.082Z
Learning: Applies to {packages/web/**,packages/landing/**}/**/*.{jsx,tsx,js,ts} : Use the `Show` component from solid-js for conditional rendering instead of JavaScript ternary operators or logical AND operators.
Applied to files:
packages/web/src/components/project-ui/overview-tab/OverviewTab.jsx
📚 Learning: 2025-12-24T17:22:48.927Z
Learnt from: CR
Repo: InfinityBowman/corates PR: 0
File: .cursor/rules/corates.mdc:0-0
Timestamp: 2025-12-24T17:22:48.927Z
Learning: Applies to packages/{web,landing}/src/**/*.{jsx,tsx} : Use Ark UI components from corates/ui package, not local component implementations
Applied to files:
packages/web/src/components/project-ui/overview-tab/OverviewTab.jsx
📚 Learning: 2025-12-19T14:49:49.730Z
Learnt from: CR
Repo: InfinityBowman/corates PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-12-19T14:49:49.730Z
Learning: Applies to packages/web/src/**/*.{js,jsx,ts,tsx} : For UI icons, use the `solid-icons` library or SVGs only. Do not use emojis
Applied to files:
packages/web/src/components/project-ui/overview-tab/OverviewTab.jsx
🧬 Code graph analysis (2)
packages/web/src/components/project-ui/ProjectView.jsx (4)
packages/web/src/components/project-ui/overview-tab/OverviewTab.jsx (1)
studies(35-35)packages/web/src/components/project-ui/all-studies-tab/AssignReviewersModal.jsx (1)
studies(29-29)packages/web/src/components/project-ui/all-studies-tab/AllStudiesTab.jsx (1)
studies(62-62)packages/web/src/lib/checklist-domain.js (1)
getChecklistCount(154-157)
packages/web/src/components/project-ui/overview-tab/OverviewTab.jsx (3)
packages/web/src/primitives/useProject/sync.js (1)
study(59-88)packages/web/src/lib/checklist-domain.js (7)
checklists(30-30)checklists(46-46)checklists(57-57)checklists(77-77)checklists(94-94)checklists(107-107)checklists(228-228)packages/web/src/constants/checklist-status.js (2)
CHECKLIST_STATUS(8-13)CHECKLIST_STATUS(8-13)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Cursor Bugbot
- GitHub Check: Workers Builds: corates
🔇 Additional comments (6)
packages/web/src/components/project-ui/overview-tab/OverviewTab.jsx (4)
59-104: LGTM - Progress calculation refactored to per-user tracking.The logic correctly tracks each reviewer's progress by counting assigned studies and checking for completed checklists. The use of
createMemoensures efficient updates.
162-207: LGTM - Stats section streamlined.The stats grid is appropriately reduced from 4 to 3 columns with the "In Progress" metric removed, and the header renamed to "Team Progress" reflects the new per-user focus.
284-299: LGTM - Label terminology updated.The progress label now correctly reads "studies appraised" which aligns with the per-user tracking model.
318-364: LGTM - Results section restructured with new Tables panel.The new "Results" section cleanly organizes Figures and Tables into separate collapsible panels with consistent styling. The placeholder message is appropriate for the initial implementation.
packages/web/src/components/project-ui/ProjectView.jsx (2)
207-209: LGTM!The implementation correctly delegates to
getChecklistCount, which handles null/undefined validation internally. The pattern is consistent withgetReconcileCount.
218-218: LGTM!The integration of count badges into the tab definitions is consistent with the existing pattern used for "To Do" and "Reconcile" tabs. Once the null check is added to
getAllStudiesCount, this will work correctly.Also applies to: 236-236
| const getAllStudiesCount = () => { | ||
| return studies().length; | ||
| }; |
There was a problem hiding this comment.
Add null/undefined check to prevent runtime error.
The function directly accesses .length on studies() without validation. If projectStore.getStudies() returns null or undefined (e.g., before the project loads), this will throw a runtime error. The defensive pattern from AssignReviewersModal (|| []) and the validation in getChecklistCount suggest this protection is needed.
Proposed fix with null check
const getAllStudiesCount = () => {
- return studies().length;
+ const studiesList = studies();
+ return studiesList?.length ?? 0;
};🤖 Prompt for AI Agents
In packages/web/src/components/project-ui/ProjectView.jsx around lines 203 to
205, getAllStudiesCount calls studies().length without guarding against
studies() being null/undefined; change the function to treat studies() as an
array by using a fallback (e.g., const s = studies() || []; return s.length;) so
it returns 0 instead of throwing when studies() is null/undefined.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on January 26
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| c.status === CHECKLIST_STATUS.AWAITING_RECONCILE, | ||
| ); | ||
|
|
||
| if (hasCompleted) { |
There was a problem hiding this comment.
Progress double-counts when same user is both reviewers
The new userProgressMap logic builds assignedUserIds by pushing both study.reviewer1 and study.reviewer2 into an array without deduplication. If these values are identical (same user assigned as both reviewers), that user's progress.total and potentially progress.completed will be incremented twice for the same study, resulting in incorrect progress percentages displayed in the UI. While the UI attempts to prevent assigning the same reviewer twice, the code lacks defensive handling for this edge case in legacy data or API bypass scenarios.
1 participant
Note
Shifts the Overview toward team-focused progress and adds lightweight results structure while displaying more counts in navigation.
getAllStudiesCountandgetCompletedCountto show badge counts forall-studiesandcompletedtabs inProjectView.jsxOverviewTab.jsx:reviewer1/reviewer2) and checklist completion/awaiting-reconcile; updates progress label wordingWritten by Cursor Bugbot for commit 872ed98. This will update automatically on new commits. Configure here.
Summary by CodeRabbit
Release Notes
New Features
UI Improvements
✏️ Tip: You can customize this high-level summary in your review settings.