-
Notifications
You must be signed in to change notification settings - Fork 0
Rename some labels #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Rename some labels #176
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
bdac3f2
Rename some labels
InfinityBowman 15408bd
amstar2 checklist must be fully filled out before can mark as complete
InfinityBowman af6523a
improve back navigation from checklist to tab
InfinityBowman 72af74e
fix errors in pdf
InfinityBowman c14fb05
reconcile pdf closed by default
InfinityBowman 01a64c6
open pdf in new tab button added to panel layout
InfinityBowman e6a1d54
rename folders
InfinityBowman e3c45f5
fix: lint and build issues
InfinityBowman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| // app.config.js | ||
| import { defineConfig } from "@solidjs/start/config"; | ||
| import tailwindcss from "@tailwindcss/vite"; | ||
| var app_config_default = defineConfig({ | ||
| vite: { | ||
| plugins: [tailwindcss()], | ||
| build: { | ||
| target: ["es2020", "safari14"] | ||
| } | ||
| }, | ||
| server: { | ||
| preset: "static", | ||
| prerender: { | ||
| routes: ["/", "/about", "/contact", "/privacy", "/resources", "/security", "/terms"], | ||
| crawlLinks: true | ||
| } | ||
| } | ||
| }); | ||
| export { | ||
| app_config_default as default | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix reactivity issue in aria-label.
Line 82 directly accesses
props.checklistTypeinside an expression, which breaks SolidJS reactivity. Prop access in JSX must be wrapped in a function or computed via a memo.Proposed fix
Create a memo for the metadata and use it in the aria-label:
export function ScoreTooltip(props) { const infoUrl = createMemo(() => getInfoUrl(props.checklistType)); const tooltipContent = createMemo(() => getTooltipContent(props.checklistType)); + const metadata = createMemo(() => getChecklistMetadata(props.checklistType)); return ( <Tooltip content={tooltipContent()} placement='bottom' openDelay={200}> <a href={infoUrl()} target='_blank' rel='noreferrer' class='mt-0.5 inline-flex items-center justify-center rounded-full p-0.5 opacity-70 hover:opacity-100 focus:opacity-100 focus:ring-2 focus:ring-blue-500 focus:outline-none' - aria-label={`Open ${getChecklistMetadata(props.checklistType).name} guidance in a new tab`} + aria-label={`Open ${metadata().name} guidance in a new tab`} > <FaSolidCircleInfo size={12} /> </a> </Tooltip> ); }🤖 Prompt for AI Agents