Skip to content

266 Move checklist logic to shared #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
InfinityBowman merged 4 commits into from
Jan 9, 2026
Merged

266 Move checklist logic to shared #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7bf395
migrate checklist definitions and logic to shared package
InfinityBowman Jan 9, 2026
d71a417
Apply Prettier formatting
actions-user Jan 9, 2026
5540fd9
ignore mocks
InfinityBowman Jan 9, 2026
5249b37
improve types, add project doc handlers for future
InfinityBowman Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .claude/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"enabledPlugins": {
"frontend-design@claude-plugins-official": true
}
}
1 change: 1 addition & 0 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,7 @@ export default [
'**/.vinxi/**',
'**/.output/**',
'**/coverage/**',
'**/mocks/**',
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify the nature of mock files and the scope of the ignore pattern

echo "=== Mocks directories found ==="
fd -t d '^mocks$'

echo -e "\n=== Count of files in mocks directories ==="
fd -t f . '**/mocks/**' | wc -l

echo -e "\n=== Sample files from mocks directories ==="
fd -t f . '**/mocks/**' | head -20

echo -e "\n=== Check for component patterns in mock files ==="
rg -t js -t jsx 'export (default )?(function|const|class)' '**/mocks/**' | head -15

echo -e "\n=== Check eslint.config.js context around line 345 ==="
sed -n '340,350p' eslint.config.js

Repository: InfinityBowman/corates

Length of output: 837

🏁 Script executed:

#!/bin/bash
# Search for mock-related patterns and files more broadly

echo "=== All directories containing 'mock' in name ==="
fd -t d -i 'mock' | head -20

echo -e "\n=== Search for mock files anywhere (js/ts) ==="
fd -t f -i 'mock' -e js -e ts -e tsx -e jsx | head -20

echo -e "\n=== Check packages/workers test setup mentioned in learnings ==="
cat packages/workers/src/__tests__/setup.js 2>/dev/null | head -30

echo -e "\n=== Git status to see if mocks directory has staged/new files ==="
git status --short packages/web/src/components/mocks/ 2>/dev/null || echo "Directory appears clean"

echo -e "\n=== Look for MSW mocks or test fixtures ==="
find . -name '*mock*' -o -name '*fixture*' -o -name '*stub*' 2>/dev/null | grep -E '\.(js|ts|tsx|jsx)$' | head -20

Repository: InfinityBowman/corates

Length of output: 1272

🏁 Script executed:

#!/bin/bash
# Check the content and nature of MockIndex.jsx

echo "=== Content of MockIndex.jsx ==="
cat packages/web/src/components/mocks/MockIndex.jsx

echo -e "\n=== File size and line count ==="
wc -l packages/web/src/components/mocks/MockIndex.jsx

echo -e "\n=== Check git history for this file ==="
git log --oneline -5 packages/web/src/components/mocks/MockIndex.jsx 2>/dev/null || echo "File is new or untracked"

Repository: InfinityBowman/corates

Length of output: 9363

Use a more specific ignore pattern for mock components.

The pattern **/mocks/** ignores all files in any directory named "mocks" throughout the project. MockIndex.jsx is actual component code (202 lines of JSX with Tailwind styling), not generated files. Even though these are marked as "temporary wireframes," they're still component files that could benefit from linting to catch syntax errors, unused variables, or style violations.

Consider using packages/web/src/components/mocks/** instead of the broad glob, which would explicitly target only these UI exploration files while avoiding unintended matches against test mocks or fixtures elsewhere in the project.

🤖 Prompt for AI Agents 
In @eslint.config.js at line 345, Replace the overly broad ignore glob
'**/mocks/**' in eslint.config.js with a more specific pattern so component mock
files like MockIndex.jsx still get linted; change the ignore entry to target
only the UI exploration folder (for example use
'packages/web/src/components/mocks/**' or an equivalent project-specific path)
to avoid excluding test mocks/fixtures while still ignoring the intended
temporary wireframes.

'packages/learn/.astro/**',
'**/.vitepress/cache/**',
'**/.vitepress/dist/**',
Expand Down
Loading