-
Notifications
You must be signed in to change notification settings - Fork 0
improve ux for robins and add missing sections #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistency: Missing
stateKeyproperties in SECTION_A.Unlike
SECTION_C(lines 170-193) which includesstateKeyfor each field,SECTION_Alacks this property. This forcesSectionA.jsxto maintain a separatefieldToStateKeymapping (lines 13-17 in SectionA.jsx), creating duplication and potential for errors.For consistency with
SECTION_Cand to eliminate the hardcoded mapping inSectionA.jsx, addstateKeyto each field:export const SECTION_A = { a1: { id: 'a1', label: 'A1', text: 'Specify the numerical result being assessed', placeholder: 'e.g., OR = 1.5 (95% CI: 1.2-1.9)', type: 'textarea', + stateKey: 'numericalResult', }, a2: { id: 'a2', label: 'A2', text: 'Provide further details about this result (for example, location in the study report, reason it was chosen)', optional: true, placeholder: 'e.g., Table 3, primary outcome analysis', type: 'textarea', + stateKey: 'furtherDetails', }, a3: { id: 'a3', label: 'A3', text: 'Specify the outcome to which this result relates', placeholder: 'e.g., All-cause mortality at 12 months', type: 'textarea', + stateKey: 'outcome', }, };Then update
SectionA.jsxto remove the hardcoded mapping (see comment in SectionA.jsx review).📝 Committable suggestion
🤖 Prompt for AI Agents