-
Notifications
You must be signed in to change notification settings - Fork 4
[algorithm] Clean up of the InsertionAlgorithm class #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[scene] Adjust scene files
…se for either puncture or insertion
[scene] Changed scenes accordingly
* Signify that the link is directed at a Geometry object
* For the needle, the name signifies whether the Geometry refers to the tip or the shaft
* For the punctured volume, the name signifies whether the Geometry will be used for:
1. the puncture and, thus, only the surface is of interest or
2. the insertion and, thus, the volume is now of interest
* The user should not care whether puncture/insertion happens "from" the
needle to the "destination" surface/volume. The user should be concerned
with appropriately defining the tip and shaft geometry as well as the
geometries of the punctured volumes and surfaces.
…d returned proximities
[scene] Adjusted scenes accordingly
… Operations functions
…ojective is set to true
epernod
reviewed
Jul 30, 2025
Not really needed
epernod
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes
1. Renamed
DetectionOutputvariablesDetection output variables have been renamed to better reflect their intended purpose:
collisionOutput: needle-surface proximity pair during the punctureinsertionOutput: needle-volume proximity pairs during the insertion phase2. Renamed links to BaseGeometry objects.
Previous naming convention gives emphasis on the directionality of the detection.
l_fromandl_dest(orl_fromVol/l_destVol) imply how proximity pairs were computed (from -> destination geometries). The user shouldn't be concerned with this.The
InsertionAlgorithmis tailored for needle insertion. In the scene, the user must specify theBaseGeometryspecializations that correspond to the nodes of the:The new names reflect these roles and signify that the links are formed between the algorithm and
BaseGeometrycomponents.3. Renamed
Operationsfunctions and proximity objectsFollowing the same logic, all the function pointers instantiated from the
Operationsnamespace have been renamed to clearly indicate:Minor changes
punctureThreshold)tipDistThreshold)sofa::namespace qualifierstypedeffor re-used multi-argument types.clang-formatshipped with main SOFA