Fix create_continuous_query method for Ruby 1.9 compatibility#150
Merged
dmke merged 1 commit intoInfluxCommunity:masterfrom Jun 7, 2016
sebcoetzee:master
Merged
Fix create_continuous_query method for Ruby 1.9 compatibility#150dmke merged 1 commit intoInfluxCommunity:masterfrom sebcoetzee:master
dmke merged 1 commit intoInfluxCommunity:masterfrom
sebcoetzee:master
Conversation
Contributor
Author
|
@dmke Pardon, I see now that this is a Ruby < 2 issue with keyword arguments. |
Contributor
|
Indeed, support for Ruby < 2.0 was dropped with v0.2.0. |
Contributor
|
Would you mind amend your PR to use an Since there are now a few 1.9 requests within a few days, I'm reconsidering 1.9 support. |
Open
Contributor
Author
|
Thanks for the quick response @dmke |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dmke please look at this, this is causing an error when requiring the gem.