Skip to content

Conversation

@karel-rehor
Copy link
Contributor

@karel-rehor karel-rehor commented May 22, 2024

Closes #

Proposed Changes

  • Add an Identity class for collecting information related to the identity of the client
  • Update user-agent of rest client to form influxdb3-java:<release>
  • Add a default user-agent metadata entry for FlightSQLClient

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@karel-rehor karel-rehor requested a review from bednar May 22, 2024 14:23
@codecov
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 88.59%. Comparing base (24ff5e5) to head (2487db0).

Files Patch % Lines
...java/com/influxdb/v3/client/internal/Identity.java 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
+ Coverage   88.53%   88.59%   +0.05%     
==========================================
  Files          15       16       +1     
  Lines         855      859       +4     
  Branches      129      129              
==========================================
+ Hits          757      761       +4     
  Misses         42       42              
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍 There is only one requirement:

Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@karel-rehor karel-rehor merged commit 18e6c1c into main May 27, 2024
@karel-rehor karel-rehor deleted the feat/userAgent branch May 27, 2024 08:14
@bednar bednar added this to the 0.8.0 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants