Skip to content

Conversation

@alespour
Copy link
Contributor

@alespour alespour commented Jul 18, 2024

Proposed Changes

Adds authScheme config property | INFLUX_AUTH_SCHEME env var | influx.authScheme java property to be used to specify non-default authentication scheme. For Cloud access does not need to be set, for Edge/OSS it should be set to Bearer.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional

@alespour
Copy link
Contributor Author

alespour commented Jul 18, 2024

Blocked by #153

@codecov
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.23%. Comparing base (c08c23a) to head (34a1f7f).

Files Patch % Lines
...va/com/influxdb/v3/client/config/ClientConfig.java 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
+ Coverage   89.19%   89.23%   +0.04%     
==========================================
  Files          16       16              
  Lines         879      892      +13     
  Branches      133      137       +4     
==========================================
+ Hits          784      796      +12     
  Misses         40       40              
- Partials       55       56       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alespour alespour marked this pull request as ready for review July 22, 2024 14:41
Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@alespour alespour merged commit b67f423 into main Jul 22, 2024
@alespour alespour deleted the fix/edge-auth branch July 22, 2024 15:01
@bednar bednar added this to the 0.9.0 milestone Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants