-
Notifications
You must be signed in to change notification settings - Fork 8
feat: add queryRows function #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 90.14% 90.19% +0.05%
==========================================
Files 19 19
Lines 1126 1142 +16
Branches 177 178 +1
==========================================
+ Hits 1015 1030 +15
Misses 41 41
- Partials 70 71 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@bednar |
karel-rehor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added comments requesting a few changes. The ones that I might insist upon are related to examples in javadoc comments, which seem to not show the method being documented. or otherwise appear to be broken.
It would be nice to extend testing.
- One or two unit tests for new methods would be nice
- The integration test could be more complete
- When testing integration it would be nice to test a couple of basic handled exceptional situations.
src/main/java/com/influxdb/v3/client/internal/VectorSchemaRootConverter.java
Show resolved
Hide resolved
|
@karel-rehor |
karel-rehor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some issues with the Javadoc examples. The arguments in many of the examples do not match the method they are documenting. Also, when looking at how the javadoc is rendered in Intellij, the formatting of the examples could be improved to be more easily readable.
|
Hi @karel-rehor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good. Sorry, it took me so long to get back to this. You might need to rebase this PR before merging.
aa3d95c to
78addd7
Compare
Hi @karel-rehor |
karel-rehor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any significant changes following rebase. Still looks good to go.
jansimonb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! 👍
2bb7cc2 to
09646f6
Compare
Closes #33
Proposed Changes
Add queryRows, which return row as a Map
Checklist