-
Notifications
You must be signed in to change notification settings - Fork 8
fix: use WriteOptions from ClientConfig on write #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
=======================================
Coverage 90.10% 90.11%
=======================================
Files 20 20
Lines 1193 1194 +1
Branches 187 187
=======================================
+ Hits 1075 1076 +1
Misses 41 41
Partials 77 77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
karel-rehor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass locally. All changes make sense. 🚴 🏁
The issue
If the client is configured as:
then the
ignores the configured write precision and uses the default precision.
Proposed Changes
The following 4 write functions in
InfluxDBClientImplnow are gettingWriteOptionsfromClientConfig config, (instead of the previously usedWriteOptions.DEFAULTS):Checklist