fix: possible memory leak in query stream close #317
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
flightStream.close()on failure: First attempt drains the stream but throws exception; retry completescleanup successfully
MemoryLeakIssueTestE2E test that reproduces the bug via thread interruptionBackground
The problem was that when a query thread is interrupted during stream consumption,
FlightStream.close()throwsInterruptedExceptionwhich bypasses cleanup code, leaving Apache Arrow buffers unreleased. This caused memory leaks(exception
"Memory was leaked by query. Memory leaked").The root cause is that
FlightStream.close()only catchesFlightRuntimeException, notInterruptedException. Wheninterrupted, the exception escapes before the cleanup block executes, leaking Arrow buffers.
Checklist