Skip to content

Fix node selector matching logic #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kerthcet merged 1 commit into from
May 29, 2025
Merged

Fix node selector matching logic #14

kerthcet merged 1 commit into from
May 29, 2025

Conversation

@carlory
Copy link
Member

@carlory carlory commented May 29, 2025

Related to #13

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels May 29, 2025
@InftyAI-Agent InftyAI-Agent requested a review from kerthcet May 29, 2025 02:02
@kerthcet
Copy link
Member

kerthcet commented May 29, 2025

/lgtm
/approve
/kind bug

@InftyAI-Agent InftyAI-Agent added lgtm Looks good to me, indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels May 29, 2025
@kerthcet
Copy link
Member

kerthcet commented May 29, 2025

We should have tests in the future.

@kerthcet kerthcet merged commit 0c2aa6d into InftyAI:main May 29, 2025
39 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kerthcet kerthcet Awaiting requested review from kerthcet

Assignees

@kerthcet kerthcet

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bug Categorizes issue or PR as related to a bug. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlory @kerthcet @InftyAI-Agent