Conversation
…viewed)". Also adapt status in the patterns accordingly. Rational: by definition the 1-Initial patterns don't have a Known Instance yet, i.e. they are not proven. Therefore we don't need an extra group to state this.
…Pattern Ideas (not yet proven; brainstormed)". Those pattern are similar in quality to the ones that we already list in "### Maturity Level 1: Initial", so they don't have to be in an extra group.
…; brainstormed)" to "Maturity Level 1: Initial". Also updating the Status in the patterens themselves. Rational: * These patterns were not all that different from the ones directl in "Maturity Level 1: Initial". * Often times they don't have a solution yet, or just a brainstormed solution. * Many of them don't have a Patlet, likely because they were written at a time when the Pattern Template didn't ask for that yet
…the Donut pattern directly, rather than to the PR. Also adapted pattern slightly to fit the current Pattern template better.
spier
added
the
Type - Maintenance / Cleanup
spier
requested review from
NewMexicoKid,
cewilliams,
gruetter,
lenucksi and
nyeates
as code owners
|
I am relatively confident that this PR can get merged. |
lenucksi
left a comment
lenucksi
left a comment
There was a problem hiding this comment.
Agree with the reasoning here and work here. LGTM to me. Merge on time-out.
There was a problem hiding this comment.
Since we're cleaning up: do we want to continue to mention affiliations? I can't think of a good reason, TBH.
There was a problem hiding this comment.
@gruetter what do you mean with "affiliations"? The company that the author of pattern is working for?
There was a problem hiding this comment.
I went through all other feedback and worked it in as best as I could.
Will merge the PR now but feel free to add a new issue for this related to your idea about the affiliations.
Co-authored-by: Georg Grütter <gruetter@gmail.com>
Co-authored-by: Georg Grütter <gruetter@gmail.com>
3 participants
Under Maturity Level 1: Initial we are listing various sub-groups, all stemming from review process that we used previously, before establishing the new maturity levels.
I decided to cleanup these groups, with the end result that most of them could be merged into the top-level group itself.
I only left the Donuts as a separate sub-group, as they felt distinctly different.
Please see the detailed commit messages below for my reasoning for the different cleanup steps.
Reviewing each commit one-by-one will likely be the easiest path to review this PR.
As part of this I also ported a Donut pattern from #38 in, as that way we were able to get rid of all references to PRs in the overview in
README.md.Original old sub-groups