Next major release #28
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adapter-as-final-class: (28 commits) CS make Adapter a final class make InMemory implement Implementation make sure to always list with a tree path representing a directory give a more easy access to the file/directory name to remove give a more easy access to the directory name being created give a more easy access to the file name being written let the bridge work with any implementation encapsulate the knownledge if the path to read is a file/directory or unknown yet use null when media type is not parseable to let use the default one change implementation type to prevent reaching an impossible case remove dead code prevent writing unchanged file/directory handle case sensitivity in the bridge let the bridge handle the logic to create/delete files/directories simplify reading from the filesystem add Implementation::remove() remove dead code remove dead code make sure the implementations only return relative names and not the full tree path ...
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #28 +/- ##
=============================================
- Coverage 99.19% 97.42% -1.78%
- Complexity 179 221 +42
=============================================
Files 15 21 +6
Lines 620 814 +194
=============================================
+ Hits 615 793 +178
- Misses 5 21 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…d be created automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is in preparation for the testing framework.
This PR will stay in this state until the whole
innmind/foundationnew API is stable enough to buildinnmind/testing.