-
-
Notifications
You must be signed in to change notification settings - Fork 726
Modify the Thresholding module's tests parameters to provide meaningul output images #1737
Copy link
Copy link
Open
Labels
area:FilteringIssues affecting the Filtering moduleIssues affecting the Filtering modulestatus:Use_Milestone_BacklogUse "Backlog" milestone instead of label for issues without a fixed deadlineUse "Backlog" milestone instead of label for issues without a fixed deadlinetype:TestingEnsure that the purpose of a class is met/the results on a wide set of test cases are correctEnsure that the purpose of a class is met/the results on a wide set of test cases are correct
Metadata
Metadata
Assignees
Labels
area:FilteringIssues affecting the Filtering moduleIssues affecting the Filtering modulestatus:Use_Milestone_BacklogUse "Backlog" milestone instead of label for issues without a fixed deadlineUse "Backlog" milestone instead of label for issues without a fixed deadlinetype:TestingEnsure that the purpose of a class is met/the results on a wide set of test cases are correctEnsure that the purpose of a class is met/the results on a wide set of test cases are correct
Description
Modify the tests in the
Thresholdingmodule so that they have appropriate parameters so as to provide a meaningful thresholded output images: e.g.itkOtsuThresholdImageFilterTestShortgenerates a thresholded output which is not really meaningful/useful (no anatomical or meaningful feature is thresholded).Steps to Reproduce
ITKDatafolder.Thresholdingmodule that do not provide meaningful images, i.e. tests whose images in theBaselinefolder are not anatomically meaningful (e.g. they contain a single value, no anatomical or meaningul structure from the input image can be distinguished, etc.).Expected behavior
Regression tests should have appropriate parameters to yield meaningful outputs for a proper check of the behavior of the filter.
Actual behavior
Some tests do not have appropriate parameters that allow to check if a meaningful/appropriate/expected thresholding is taking place.
Reproducibility
100%.
Versions
masterEnvironment
All environments.
Additional Information
See this comment and the context in PR #511.
@richardbeare your insight is highly appreciated.