Skip to content

Modify the Thresholding module's tests parameters to provide meaningul output images #1737

@jhlegarreta

Description

@jhlegarreta

Description

Modify the tests in the Thresholding module so that they have appropriate parameters so as to provide a meaningful thresholded output images: e.g. itkOtsuThresholdImageFilterTestShort generates a thresholded output which is not really meaningful/useful (no anatomical or meaningful feature is thresholded).

Steps to Reproduce

  1. Configure and build ITK, including the ITKData folder.
  2. Identify the tests in the Thresholding module that do not provide meaningful images, i.e. tests whose images in the Baseline folder are not anatomically meaningful (e.g. they contain a single value, no anatomical or meaningul structure from the input image can be distinguished, etc.).
  3. Modify the test parameters so that meaningful output data is generated..

Expected behavior

Regression tests should have appropriate parameters to yield meaningful outputs for a proper check of the behavior of the filter.

Actual behavior

Some tests do not have appropriate parameters that allow to check if a meaningful/appropriate/expected thresholding is taking place.

Reproducibility

100%.

Versions

master

Environment

All environments.

Additional Information

See this comment and the context in PR #511.

@richardbeare your insight is highly appreciated.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:FilteringIssues affecting the Filtering modulestatus:Use_Milestone_BacklogUse "Backlog" milestone instead of label for issues without a fixed deadlinetype:TestingEnsure that the purpose of a class is met/the results on a wide set of test cases are correct

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions