-
-
Notifications
You must be signed in to change notification settings - Fork 726
Uncomment and fix Thresholding module tests #1738
Copy link
Copy link
Open
Labels
area:FilteringIssues affecting the Filtering moduleIssues affecting the Filtering modulestatus:Use_Milestone_BacklogUse "Backlog" milestone instead of label for issues without a fixed deadlineUse "Backlog" milestone instead of label for issues without a fixed deadlinetype:BugInconsistencies or issues which will cause an incorrect result under some or all circumstancesInconsistencies or issues which will cause an incorrect result under some or all circumstances
Metadata
Metadata
Assignees
Labels
area:FilteringIssues affecting the Filtering moduleIssues affecting the Filtering modulestatus:Use_Milestone_BacklogUse "Backlog" milestone instead of label for issues without a fixed deadlineUse "Backlog" milestone instead of label for issues without a fixed deadlinetype:BugInconsistencies or issues which will cause an incorrect result under some or all circumstancesInconsistencies or issues which will cause an incorrect result under some or all circumstances
Description
Fix and uncomment the
itkIntermodesThresholdImageFilterTestNoAutoMinMaxanditkOtsuThresholdCalculatorVersusOtsuMultipleThresholdsCalculatorTesttests in theThresholdingmodule. They were commented to so that the related PR could be moved forward and be merged.Steps to Reproduce
itkIntermodesThresholdImageFilterTestNoAutoMinMaxanditkOtsuThresholdCalculatorVersusOtsuMultipleThresholdsCalculatorTesttests.and
from the binaries directory.
Expected behavior
Both tests should pass and yield the expected results.
Actual behavior
None of the two tests pass:
itkIntermodesThresholdImageFilterTestNoAutoMinMaxexceeds the allowed number maximum number of smoothing iterations, whatever its value is.itkOtsuThresholdCalculatorVersusOtsuMultipleThresholdsCalculatorTestfails when comparing the values of the values yielded byitk::OtsuThresholdsCalculatorand theitk::OtsuMultipleThresholdsCalculatorinstances.Reproducibility
%100.
Versions
master.Environment
All environments.
Additional Information
See this comment and the context in PR #511.
@richardbeare may be you have some intuition of what the cause may be.