Skip to content

Uncomment and fix Thresholding module tests #1738

@jhlegarreta

Description

@jhlegarreta

Description

Fix and uncomment the itkIntermodesThresholdImageFilterTestNoAutoMinMax and itkOtsuThresholdCalculatorVersusOtsuMultipleThresholdsCalculatorTest tests in the Thresholding module. They were commented to so that the related PR could be moved forward and be merged.

Steps to Reproduce

  1. Uncomment itkIntermodesThresholdImageFilterTestNoAutoMinMax and itkOtsuThresholdCalculatorVersusOtsuMultipleThresholdsCalculatorTest tests.
  2. Configure and build ITK.
  3. Run the tests, e.g.
ctest -V -R itkIntermodesThresholdImageFilterTestNoAutoMinMax -C Debug

and

ctest -V -R itkOtsuThresholdCalculatorVersusOtsuMultipleThresholdsCalculatorTest -C Debug

from the binaries directory.

Expected behavior

Both tests should pass and yield the expected results.

Actual behavior

None of the two tests pass:

  • itkIntermodesThresholdImageFilterTestNoAutoMinMax exceeds the allowed number maximum number of smoothing iterations, whatever its value is.
  • itkOtsuThresholdCalculatorVersusOtsuMultipleThresholdsCalculatorTest fails when comparing the values of the values yielded by itk::OtsuThresholdsCalculator and the itk::OtsuMultipleThresholdsCalculator instances.

Reproducibility

%100.

Versions

master.

Environment

All environments.

Additional Information

See this comment and the context in PR #511.

@richardbeare may be you have some intuition of what the cause may be.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:FilteringIssues affecting the Filtering modulestatus:Use_Milestone_BacklogUse "Backlog" milestone instead of label for issues without a fixed deadlinetype:BugInconsistencies or issues which will cause an incorrect result under some or all circumstances

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions