STYLE: Prefer c++11 'using' to 'typedef'#1047
Merged
dzenanz merged 2 commits intoInsightSoftwareConsortium:masterfrom Jul 1, 2019
Merged
STYLE: Prefer c++11 'using' to 'typedef'#1047dzenanz merged 2 commits intoInsightSoftwareConsortium:masterfrom
dzenanz merged 2 commits intoInsightSoftwareConsortium:masterfrom
Conversation
dzenanz
reviewed
Jun 30, 2019
Describe function overrides using the override keyword from C++11. SRCDIR=/localscratch/Users/johnsonhj/src/AZTEST/ITKEx-bld/ITK #My local SRC BLDDIR=/localscratch/Users/johnsonhj/src/AZTEST/ITKEx-bld/ITK-clang9 #My local BLD cd /localscratch/Users/johnsonhj/src/AZTEST/ITKEx-bld/ITK-clang9 run-clang-tidy.py -extra-arg=-D__clang__ -checks=-*,modernize-use-override -header-filter=.* -fix
Keep the naming style consistent with c++11 recommended style.
hjmjohnson
force-pushed
the
prefer-using-to-typedef
branch
from
c716ba9 to
4ab1b93
Compare
Member
Author
|
@dzenanz Please merge if you approve. |
dzenanz
approved these changes
Jul 1, 2019
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
The amended version seems to be more comprehensive!
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Jan 5, 2022
Ran LLVM 13.0.0 Clang-Tidy check `modernize-use-using`: https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-using.html Did Notepad++ v8.1.9.3 Find in Files Find what: typedef (\w+) [ ]*(\w+); Replace with: using $2 = $1; [v] Match case (*) Regular expression Following ITK "STYLE: Prefer c++11 'using' to 'typedef'": - pull request InsightSoftwareConsortium/ITK#1628 commit InsightSoftwareConsortium/ITK@32f6f1e by Hans Johnson, 20 February 2020. - pull request InsightSoftwareConsortium/ITK#1047 commit InsightSoftwareConsortium/ITK@f42f88b by Hans Johnson, Dženan Zukić, 1 July 2019 In accordance with C++ Core Guidelines, January 3, 2022: "Prefer `using` over `typedef` for defining aliases", https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rt-using
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.