STYLE: Prepare for clang format style enforcement#1094
Merged
hjmjohnson merged 7 commits intoInsightSoftwareConsortium:masterfrom Jul 16, 2019
Merged
STYLE: Prepare for clang format style enforcement#1094hjmjohnson merged 7 commits intoInsightSoftwareConsortium:masterfrom
hjmjohnson merged 7 commits intoInsightSoftwareConsortium:masterfrom
Conversation
Fix compilation issues due to untested code refactorings when matching ITK v5 coding conventions.
Modules/Numerics/FEM/src/dsrc2c.c with size 246224 bytes (240.45 KiB) which is greater than the maximum size 100000 bytes
Member
|
LGTM. |
jhlegarreta
requested changes
Jul 15, 2019
Member
jhlegarreta
left a comment
jhlegarreta
left a comment
There was a problem hiding this comment.
Thanks @hjmjohnson . A few in-line comments.
These long-standing kwstyle violations are explicitly ignored to allow clean testing.
Use more transparent coding of templated type-checked functions rather than partial-code-chunk macros.
hjmjohnson
force-pushed
the
prepare-for-clang-format
branch
from
af374bb to
a448dac
Compare
dzenanz
approved these changes
Jul 15, 2019
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
Generally looks good. It would be good if you added some forgotten if-clauses.
Add support for LONGLONG and ULONGLONG types for completeness.
dzenanz
approved these changes
Jul 15, 2019
dzenanz
reviewed
Jul 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide initial code changes to facilitate enforcement of an ITK style that can be uniformly applied in an automated way.
These problems appeared when enforcing a consistent style with the clang-formatting tool. It is a first step towards providing an easier code formatting style enforcement throughout ITK.