BUG: Fix GaussianInterpolateImageFunction with streaming#1202
Merged
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom Aug 28, 2019
maekclena:fix_gaussian_streaming
Merged
BUG: Fix GaussianInterpolateImageFunction with streaming#1202thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom maekclena:fix_gaussian_streaming
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom
maekclena:fix_gaussian_streaming
Conversation
thewtex
approved these changes
Aug 26, 2019
Member
thewtex
left a comment
thewtex
left a comment
There was a problem hiding this comment.
@maekclena thanks!
@romangrothausmann could you please test?
dzenanz
reviewed
Aug 26, 2019
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
I wonder whether this fixes it. I have a feeling that I tried things like this.
Member
Member
Tests pass. |
This was referenced May 2, 2026
hjmjohnson
added a commit
to romangrothausmann/ITK
that referenced
this pull request
May 4, 2026
Regression guard for issue InsightSoftwareConsortium#1011 (fixed by InsightSoftwareConsortium#1202): a Gaussian-interpolated ResampleImageFilter must produce the same output whether or not its downstream is streamed. Reverts of the bounding-box fix (BufferedRegion vs LargestPossibleRegion) reproduce a 28672 / 32768-pixel divergence with NaN output values. A CastImageFilter is inserted upstream of the resampler so the bug surfaces; an in-memory image's BufferedRegion never shrinks under streaming, which is why the abandoned WIP draft InsightSoftwareConsortium#1012 no longer reproduced. Supersedes InsightSoftwareConsortium#1012 by @romangrothausmann; uses the modern GTest harness and fits as a TEST block in itkResampleImageFilterGTest. Co-Authored-By: Roman Grothausmann <roman.grothausmann@mh-hannover.de>
hjmjohnson
pushed a commit
to hjmjohnson/ITK
that referenced
this pull request
May 6, 2026
…gaussian_streaming BUG: Fix GaussianInterpolateImageFunction with streaming
hjmjohnson
added a commit
to blowekamp/ITK
that referenced
this pull request
May 6, 2026
Regression guard for issue InsightSoftwareConsortium#1011 (fixed by InsightSoftwareConsortium#1202): a Gaussian-interpolated ResampleImageFilter must produce the same output whether or not its downstream is streamed. Reverts of the bounding-box fix (BufferedRegion vs LargestPossibleRegion) reproduce a 28672 / 32768-pixel divergence with NaN output values. A CastImageFilter is inserted upstream of the resampler so the bug surfaces; an in-memory image's BufferedRegion never shrinks under streaming, which is why the abandoned WIP draft InsightSoftwareConsortium#1012 no longer reproduced. Supersedes InsightSoftwareConsortium#1012 by @romangrothausmann; uses the modern GTest harness and fits as a TEST block in itkResampleImageFilterGTest. Co-Authored-By: Roman Grothausmann <roman.grothausmann@mh-hannover.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1011.
The bounding box needs to be computed on the whole image.
PR Checklist