Run clang-format on pre-commit#1213
Merged
hjmjohnson merged 7 commits intoInsightSoftwareConsortium:masterfrom Aug 29, 2019
Merged
Run clang-format on pre-commit#1213hjmjohnson merged 7 commits intoInsightSoftwareConsortium:masterfrom
hjmjohnson merged 7 commits intoInsightSoftwareConsortium:masterfrom
Conversation
This configuration variable is set by ITK/Utilities/ClangFormat/DownloadClangFormat.cmake and ITK/CMake/ITKModuleClangFormat.cmake.
Check before running the hook, which will run, if available.
This was referenced Aug 28, 2019
dzenanz
approved these changes
Aug 28, 2019
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
I haven't tested this, but looks good.
bradking
reviewed
Aug 28, 2019
Contributor
|
This looks good, all - just catching up on the thread. |
hjmjohnson
reviewed
Aug 28, 2019
| * hooks-max-size=100000 | ||
| Modules/Numerics/FEM/src/dsrc2c.c hooks-max-size=260000 | ||
| Modules/ThirdParty/** hooks-max-size=300000 | ||
| Modules/ThirdParty/** hooks-max-size=300000 hooks.style= |
Various improvements and fixes: - The default merged output is now the output of clang-format. - KWStyle and clangformat style checks are enabled by default. - Console input specification fixed for the mergetool. - Partially staged files without the style hook attributes are automatically skipped.
Suggested-by: Brad King <brad.king@kitware.com>
thewtex
force-pushed
the
pre-commit-clang-format
branch
from
543ed08 to
cc6a5e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically run
clang-formaton changed, non-third-party C++ files at pre-commit time, and allow the developer to review and test the style changes with the standardgit mergetoolconfiguration (seegit help mergetool).This should be merged after #1191 since most of the files in the repository currently have many changes when clang-format is executed.