Skip to content

COMP: Fixed IndexRange warnings -Wshadow -Wmissing-field-initializers#171

Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
N-Dekker:Fix-IndexRange-warnings
Nov 13, 2018
Merged

COMP: Fixed IndexRange warnings -Wshadow -Wmissing-field-initializers#171
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
N-Dekker:Fix-IndexRange-warnings

Conversation

@N-Dekker
Copy link
Copy Markdown
Contributor

Fixed two types of warnings from Linux-x86_64-gcc4.8-m32:

itkIndexRange.h:298:5: warning: declaration of 'size' shadows a member of 'this' [-Wshadow]

itkIndexRangeGTest.cxx: warning: missing initializer for member 'itk::Index<2u>::m_InternalArray' [-Wmissing-field-initializers]

Reported by Hans J Johnson @hjmjohnson

Fixed two types of warnings from Linux-x86_64-gcc4.8-m32:

itkIndexRange.h:298:5: warning: declaration of 'size' shadows a member of 'this' [-Wshadow]

itkIndexRangeGTest.cxx: warning: missing initializer for member 'itk::Index<2u>::m_InternalArray' [-Wmissing-field-initializers]

Reported by Hans J Johnson @hjmjohnson
@N-Dekker
Copy link
Copy Markdown
Contributor Author

My remaining question from #155 (comment) :

Do you know why these warnings did not appear before? At least I did not see them at the commit https://github.com/InsightSoftwareConsortium/ITK/pull/155/commits or at the Linux build results from Azure https://dev.azure.com/itkrobotlinux/ITK.Linux/_build/results?buildId=194&view=logs

@hjmjohnson hjmjohnson requested a review from thewtex November 13, 2018 12:01
@hjmjohnson hjmjohnson self-assigned this Nov 13, 2018
@dzenanz dzenanz merged commit c6cb215 into InsightSoftwareConsortium:master Nov 13, 2018
@N-Dekker N-Dekker deleted the Fix-IndexRange-warnings branch November 13, 2018 18:10
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request Apr 19, 2026
hjmjohnson pushed a commit that referenced this pull request Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants