ENH: Added policy for constant NeighborhoodRange values outside image#212
Merged
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom Nov 26, 2018
N-Dekker:Added-ConstantBoundaryImageNeighborhoodPixelAccessPolicy
Merged
ENH: Added policy for constant NeighborhoodRange values outside image#212thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom N-Dekker:Added-ConstantBoundaryImageNeighborhoodPixelAccessPolicy
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom
N-Dekker:Added-ConstantBoundaryImageNeighborhoodPixelAccessPolicy
Conversation
Added ConstantBoundaryImageNeighborhoodPixelAccessPolicy - a policy to get a specified constant value from ShapedImageNeighborhoodRange when a pixel value outside the image is queried. Equivalent to itk::ConstantBoundaryCondition with itk::ConstNeighborhoodIterator. Adapted ShapedImageNeighborhoodRange to allow the user to specify an optional pixel access parameter. This parameter allows specifying the constant value for this policy. A policy class that supports this pixel access parameter must have a nested PixelAccessParameterType type. Change-Id: I5a1ae9f918a31d03a4dd3d84ceedd4385ab4ec7d
Contributor
|
Could you add a github comment adding the context of this? A link to your other PR with the same aim, and changes made when compared with the other approach. This looks somehow isolated from older discussions, when it is not. Thanks! |
Contributor
Author
|
@phcerdan History of this issue:
This pull request ( #212 ) has removed the template parameter |
Contributor
|
Thanks @N-Dekker, the comment helps a lot, and it is awesome that you were able to do this without the template parameter in |
thewtex
approved these changes
Nov 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ConstantBoundaryImageNeighborhoodPixelAccessPolicy - a policy to get a specified constant value from ShapedImageNeighborhoodRange when a pixel value outside the image is queried. Equivalent to itk::ConstantBoundaryCondition with itk::ConstNeighborhoodIterator.
Adapted ShapedImageNeighborhoodRange to allow the user to specify an optional pixel access parameter. This parameter allows specifying the constant value for this policy. A policy class that supports this pixel access parameter must have a nested PixelAccessParameterType type.