Skip to content

STYLE: Use the WriteImage convenience function anywhere in Modules/Core#2173

Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom
N-Dekker:Use-WriteImage-in-Core-Mesh
Dec 12, 2020
Merged

STYLE: Use the WriteImage convenience function anywhere in Modules/Core#2173
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom
N-Dekker:Use-WriteImage-in-Core-Mesh

Conversation

@N-Dekker
Copy link
Copy Markdown
Contributor

Replaced explicit creation of itk::ImageFileWriter objects by calling
the new itk::WriteImage convenience function. Aims to reduces the
amount of boilerplate code.

@N-Dekker N-Dekker changed the title STYLE: Use the WriteImage convenience function in Core/Mesh STYLE: Use the WriteImage convenience function in Core/Mesh + Core/Transform Dec 11, 2020
@N-Dekker
Copy link
Copy Markdown
Contributor Author

@hjmjohnson Thanks for your approval. With the next force-push, I'll squash all proposed Core changes, and add a few more 😃

@N-Dekker N-Dekker force-pushed the Use-WriteImage-in-Core-Mesh branch from 422e7be to b41f4ce Compare December 11, 2020 21:57
@N-Dekker N-Dekker changed the title STYLE: Use the WriteImage convenience function in Core/Mesh + Core/Transform STYLE: Use the WriteImage convenience function in anywhere in Core Dec 11, 2020
@N-Dekker N-Dekker force-pushed the Use-WriteImage-in-Core-Mesh branch from b41f4ce to fa0a298 Compare December 11, 2020 22:00
@N-Dekker N-Dekker changed the title STYLE: Use the WriteImage convenience function in anywhere in Core STYLE: Use the WriteImage convenience function anywhere in Modules/Core Dec 11, 2020
@N-Dekker N-Dekker marked this pull request as ready for review December 11, 2020 22:02
Replaced explicit creation of `itk::ImageFileWriter` objects by calling
the new `itk::WriteImage` convenience function. Aims to reduces the
amount of boilerplate code.
@N-Dekker N-Dekker force-pushed the Use-WriteImage-in-Core-Mesh branch from fa0a298 to 8bca90a Compare December 12, 2020 13:13
@N-Dekker
Copy link
Copy Markdown
Contributor Author

Force-pushed, just having done git rebase master on this PR branch, in order to include pull request #2165 commit d8af208 "ENH: remove redundant WriteImage overloads" by Dženan (@dzenanz) and Bradley (@blowekamp).

@hjmjohnson hjmjohnson merged commit 91418de into InsightSoftwareConsortium:master Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants