STYLE: Remove 9 no-op dynamic_casts (casting T* to T*)#2365
Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom Mar 4, 2021
Merged
Conversation
Removed nine "no-op" dynamic_casts that just cast pointers to their own compile-time type. Note: in those cases where `auto` was used to declare a variable initialized by such a no-op `dynamic_cast`, this commit replaced `auto` by the explicitly specified declaration type.
Contributor
Author
|
Follow-up to pull request #2360 (which specifically did Modules/Core). |
dzenanz
approved these changes
Mar 4, 2021
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Mar 17, 2021
Removed the three "no-op" dynamic_casts of `this->GetPosteriorImage()` from the implementation of `BayesianClassifierImageFilter`. Follow-up to: pull request InsightSoftwareConsortium#2365 commit 5089a04 "STYLE: Remove 9 no-op dynamic_casts (casting T* to T*)"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed nine "no-op" dynamic_casts that just cast pointers to their own
compile-time type.
Note: in those cases where
autowas used to declare a variableinitialized by such a no-op
dynamic_cast, this commit replacedautoby the explicitly specified declaration type.