STYLE: Remove unintended extra space from destructors and operators#2368
Conversation
Thanks Dženan! I just looked at those destructors and saw some "space" for improvement 😸 |
N-Dekker
force-pushed
the
Remove-extra-space-from-destructor
branch
from
7f662da to
b1a8642
Compare
N-Dekker
changed the title
|
@dzenanz I just added similar cosmetic fixes to |
@hjmjohnson If I understand correctly, it isn't really a bug. When the class name and the colons were originally separated by a line-break, clang-format just does not have "the guts" to glue them together. It needs our help 😃 Once the class name and the colons are attached without a space, clang-format does not take them apart anymore. As far as I see. |
@N-Dekker AWESOME! Thank you for checking. Then this is a fabulous change! |
Thank you Hans! For the record, these Clang-Format issues appear related:
Both submitted by Pablo Martin-Gomez. |
It appears that clang-format (version 8.0.1) has in some cases introduced an unintended space character between the class name and the `::`, in the definition of a destructor or overloaded `operator`. This typically seems to have happened when there originally was a line break between the class name and the colon characters. Follow-up to: "STYLE: Remove space between class and member names in C++ source files" pull request InsightSoftwareConsortium#2096 commit 734d6f8 Related to "Bug 44189 - clang-format does not remove space between non-macro identifier and ::", reported by Pablo Martin-Gomez, 2019-12-01 https://bugs.llvm.org/show_bug.cgi?id=44189
N-Dekker
force-pushed
the
Remove-extra-space-from-destructor
branch
from
26170be to
c7c83d9
Compare
N-Dekker
changed the title
|
FYI, my last force-push just squashed the two commits into one. |
4 participants
It appears that clang-format has in some cases introduced an unintended
space character between the class name and the
::~, in the definitionof a destructor. This typically seems to have happened when there
originally was a line break between the class name and the colon
characters.
Follow-up to:
"STYLE: Remove space between class and member names in C++ source files"
pull request #2096
commit 734d6f8