STYLE: C++11 inheriting constructors and Rule of Zero for ExceptionObject derived classes#2398
Merged
dzenanz merged 2 commits intoInsightSoftwareConsortium:masterfrom Mar 12, 2021
Conversation
`MemoryAllocationError`, `RangeError`, `InvalidArgumentError`, and `IncompatibleOperandsError` may simply inherit the constructors from their base class, `itk::ExceptionObject`.
Removed the explicit declaration and definition of destructors from the derived exception classes defined in "itkExceptionObject.h", following the C++ "Rule of Zero".
N-Dekker
changed the title
Contributor
Author
|
FYI Added an extra commit, which removes the explicit destructor declarations and definitions from those classes. |
dzenanz
approved these changes
Mar 12, 2021
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Mar 14, 2021
Follow-up to: Pull request InsightSoftwareConsortium#2398 Commit e41b2ef "STYLE: C++11 inheriting constructors from ExceptionObject for 4 classes"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MemoryAllocationError,RangeError,InvalidArgumentError, andIncompatibleOperandsErrormay simply inherit the constructors fromtheir base class,
itk::ExceptionObject.