BUG: Fix regression in PolygonSpatialObject::IsInsideInObjectSpace#2453
Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:releasefrom Mar 29, 2021
Merged
Conversation
This was referenced Mar 29, 2021
This is a followup to the bugfix for issue InsightSoftwareConsortium#1082 where there was a regression in the code on determining the inside/outsideness of points. There are some cases where the algorithm still fails as there are two boundary checks in the code which should be identical. 1. Test on adjacent segment pairs from start to finish 2. Test on segment pair from finish point to start point on closed polygons. The previous bugfix fixed the code in item 1, but did not update the check (which should be identical in item 2). This should address this issue making both boundary on segments the same.
dzenanz
force-pushed
the
PolygonSpatalObjectRegression-fix
branch
from
f4dda67 to
e3bf8e9
Compare
Member
Author
|
Force-push sets the intensity difference tolerance to zero (from default two) to make sure the test fails without the fix. If default inside value of 255 was used, this would not have been necessary. If someone doesn't mind making the change and regenerating the test baseline they are welcome to update my branch. |
jhlegarreta
reviewed
Mar 29, 2021
Member
jhlegarreta
left a comment
jhlegarreta
left a comment
There was a problem hiding this comment.
Maybe the commit could be drawn from the master branch once it gets merged? (not sure how the sync is handled when it is required)
Member
Author
|
This commit merges cleanly into master, as PR #2454 shows. |
jhlegarreta
approved these changes
Mar 29, 2021
Member
Author
|
The failures are unrelated. Merging. |
hjmjohnson
pushed a commit
to hjmjohnson/ITK
that referenced
this pull request
May 6, 2026
…nSpatalObjectRegression-fix BUG: Fix regression in PolygonSpatialObject::IsInsideInObjectSpace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a slightly cleaned-up clone of #2422.