STYLE: Make test style more consistent#2534
Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom May 18, 2021
Merged
STYLE: Make test style more consistent#2534dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
Conversation
jhlegarreta
requested review from
Leengit,
N-Dekker,
blowekamp,
dzenanz,
hjmjohnson and
thewtex
Member
Author
|
Note that this change does not mean to be exhaustive at all. I just came across these cases while I was working on #2327. Thanks. |
github-actions
Bot
added
area:Filtering
Leengit
reviewed
May 17, 2021
Contributor
Leengit
left a comment
Leengit
left a comment
There was a problem hiding this comment.
Looks good. I'd approve the merge, but I think you should get someone else's eyes on this too.
dzenanz
approved these changes
May 17, 2021
Make test style more consistent: - Use the ITK testing macros to reduce boilerplate code. - Increase consistency in the missing argument check message and test ending messages. - Define the constant expressions (e.g. the image dimensionality) at a single place at the beginning of the tests. - Use the ITK C++ coding style (e.g. do not capitalize first letter in local variable names, etc.). Take advantage of the commit to fix some typos.
jhlegarreta
force-pushed
the
ImproveTestsStyle
branch
from
4fa614f to
79c65d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make test style more consistent:
ending messages.
single place at the beginning of the tests.
local variable names, etc.).
Take advantage of the commit to fix some typos.
PR Checklist