Skip to content

STYLE: Improve style in miscellaneous files#2535

Merged
N-Dekker merged 1 commit intoInsightSoftwareConsortium:masterfrom
jhlegarreta:MiscellaneousStyleImprovements
May 18, 2021
Merged

STYLE: Improve style in miscellaneous files#2535
N-Dekker merged 1 commit intoInsightSoftwareConsortium:masterfrom
jhlegarreta:MiscellaneousStyleImprovements

Conversation

@jhlegarreta
Copy link
Copy Markdown
Member

Improve style in miscellaneous files:

  • Remove unnecessary separator comment lines to improve readability.
  • Remove unnecessary comments at closing braces.
  • Capitalize comment sentences.

Take advantage of the commit to:

  • Improve the wording in some comments.
  • Fix some typos.

PR Checklist

@github-actions github-actions Bot added area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:Numerics Issues affecting the Numerics module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module type:Style Style changes: no logic impact (indentation, comments, naming) labels May 15, 2021
@jhlegarreta
Copy link
Copy Markdown
Member Author

Note that this change does not mean to be exhaustive at all. I just visited this files cases while I was working on #2327. I grant that some of these style changes might fall in the land of preferences. Thanks.

@jhlegarreta jhlegarreta force-pushed the MiscellaneousStyleImprovements branch from 56a8959 to bed9c21 Compare May 15, 2021 19:18
Improve style in miscellaneous files:
- Remove unnecessary separator comment lines to improve readability.
- Remove unnecessary comments at closing braces.
- Capitalize comment sentences.

Take advantage of the commit to:
- Improve the wording in some comments.
- Fix some typos.
@jhlegarreta jhlegarreta force-pushed the MiscellaneousStyleImprovements branch from bed9c21 to 46452e4 Compare May 15, 2021 21:21
Copy link
Copy Markdown
Contributor

@N-Dekker N-Dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@N-Dekker N-Dekker merged commit 68d73ba into InsightSoftwareConsortium:master May 18, 2021
@jhlegarreta jhlegarreta deleted the MiscellaneousStyleImprovements branch May 18, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:Numerics Issues affecting the Numerics module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module type:Style Style changes: no logic impact (indentation, comments, naming)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants