Skip to content

ENH: Add missing getter method to itk::LaplacianOperator ivar#2547

Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
jhlegarreta:AddDerivativeScalingsGetterToLaplacianOperat
May 27, 2021
Merged

ENH: Add missing getter method to itk::LaplacianOperator ivar#2547
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
jhlegarreta:AddDerivativeScalingsGetterToLaplacianOperat

Conversation

@jhlegarreta
Copy link
Copy Markdown
Member

@jhlegarreta jhlegarreta commented May 19, 2021

Add missing getter method to itk::LaplacianOperator class ivar.

PR Checklist

@github-actions github-actions Bot added area:Core Issues affecting the Core module type:Enhancement Improvement of existing methods or implementation labels May 19, 2021
@jhlegarreta jhlegarreta force-pushed the AddDerivativeScalingsGetterToLaplacianOperat branch from 56e1b63 to 6f8b74a Compare May 19, 2021 22:29
@jhlegarreta jhlegarreta force-pushed the AddDerivativeScalingsGetterToLaplacianOperat branch 2 times, most recently from 4edff5d to 84ca657 Compare May 19, 2021 23:18
@jhlegarreta
Copy link
Copy Markdown
Member Author

Ain't there a way to use Get macros to return a const pointer?

@Leengit
Copy link
Copy Markdown
Contributor

Leengit commented May 20, 2021

There's itkGetConstMacro(DerivativeScalings, const double *) using the macro defined in Modules/Core/Common/include/itkMacro.h.

Add missing getter method to `itk::LaplacianOperator` class ivar.
@jhlegarreta jhlegarreta force-pushed the AddDerivativeScalingsGetterToLaplacianOperat branch from 84ca657 to 787827e Compare May 20, 2021 22:22
@jhlegarreta
Copy link
Copy Markdown
Member Author

There's itkGetConstMacro(DerivativeScalings, const double *) using the macro defined in Modules/Core/Common/include/itkMacro.h.

Thanks @Leengit. Changed in 787827e. Let's see if the CIs are happy.

@dzenanz dzenanz merged commit d94d9ed into InsightSoftwareConsortium:master May 27, 2021
@jhlegarreta jhlegarreta deleted the AddDerivativeScalingsGetterToLaplacianOperat branch May 27, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Core Issues affecting the Core module type:Enhancement Improvement of existing methods or implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants