STYLE: Make work unit naming consistent#2695
Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom Aug 17, 2021
Merged
Conversation
github-actions
Bot
added
area:Core
dzenanz
reviewed
Aug 16, 2021
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
Looks mostly good.
Please squash all changes into one commit and rebase on master.
dzenanz
approved these changes
Aug 16, 2021
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
To be squashed upon merge, if not squashed before.
A new multi-threading mechanism was introduced in commit 2075084, and this led to some variables being stuck in the old naming system. We see *thread* counts and IDs showing up in variable names where the new system should reference *work unit* counts and IDs. This commit renames those variables. Resolves InsightSoftwareConsortium#86
ebrahimebrahim
force-pushed
the
consistent_variable_naming_for_work_units
branch
from
4630635 to
03024da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new multi-threading mechanism was introduced in commit 2075084,
and this led to some variables being stuck in the old naming system.
We see thread counts and IDs showing up in variable names where
the new system should reference work unit counts and IDs.
This commit renames those variables.
Resolves #86
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.