Skip to content

ENH: enable ITKReview module for better CI test coverage#2754

Merged
hjmjohnson merged 1 commit intodashboardfrom
enableReviewCI
Sep 23, 2021
Merged

ENH: enable ITKReview module for better CI test coverage#2754
hjmjohnson merged 1 commit intodashboardfrom
enableReviewCI

Conversation

@dzenanz
Copy link
Copy Markdown
Member

@dzenanz dzenanz commented Sep 23, 2021

This only enables it for CircleCI, but it was a quick edit.

@hjmjohnson hjmjohnson merged commit 279b3c0 into dashboard Sep 23, 2021
@jhlegarreta jhlegarreta deleted the enableReviewCI branch September 23, 2021 16:17
@jhlegarreta
Copy link
Copy Markdown
Member

jhlegarreta commented Sep 25, 2021

Not sure if this is taking effect, as #2756 showed a passing status. Maybe the cache is being restored ??
https://github.com/InsightSoftwareConsortium/ITK/blob/master/.circleci/config.yml#L37

Even this PR should have failed for CircleCI.

The same should happen for the master branch. It does report the Review module failures:
https://app.circleci.com/pipelines/github/InsightSoftwareConsortium/ITK/3433/workflows/1fdcaf73-8725-4170-8872-3c250d20615e/jobs/10188/steps

The current failure is unrelated to the Review module issues.

@dzenanz
Copy link
Copy Markdown
Member Author

dzenanz commented Sep 27, 2021

Judging by this recent build, Review is being turned on. And this test run confirms it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants