BUG: fix a crash in QuadEdgeMeshFilter tests#2788
Merged
hjmjohnson merged 3 commits intoInsightSoftwareConsortium:masterfrom Oct 29, 2021
Merged
BUG: fix a crash in QuadEdgeMeshFilter tests#2788hjmjohnson merged 3 commits intoInsightSoftwareConsortium:masterfrom
hjmjohnson merged 3 commits intoInsightSoftwareConsortium:masterfrom
Conversation
github-actions
Bot
added
area:Core
N-Dekker
reviewed
Oct 8, 2021
Contributor
Nice catch! I guess this bug might cause a crash on any platform or compiler version, right? |
Member
Author
|
Yes, it is a bug which can affect any platform and compiler. I am switching it to draft until I have time to fix the compile errors caused by this change. |
2 tasks
dzenanz
force-pushed
the
quadEdgeMeshCrash
branch
from
bb2b952 to
8f98bd9
Compare
dzenanz
force-pushed
the
quadEdgeMeshCrash
branch
from
8f98bd9 to
aecf0d3
Compare
github-actions
Bot
added
type:Infrastructure
itkSquaredEdgeLengthDecimationQuadEdgeMeshFilterTest itkQuadricDecimationQuadEdgeMeshFilterTest were crashing in Debug mode on Visual Studio 2017. The element is used for its type, so the actual access is optimized away in Release mode. In these tests, the cell/pixel data did not have an element with key 0, so trying to access it caused a crash.
dzenanz
force-pushed
the
quadEdgeMeshCrash
branch
from
aecf0d3 to
377dc9d
Compare
Member
Author
|
The other two commits are not required. Just something I noticed while working on this bug. |
Member
OK. |
hjmjohnson
approved these changes
Oct 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
itkSquaredEdgeLengthDecimationQuadEdgeMeshFilterTest
itkQuadricDecimationQuadEdgeMeshFilterTest
were crashing in Debug mode on Visual Studio 2017.
The element is used for its type, so the actual access is optimized away in Release mode. In these tests, the cell/pixel data did not have an element with key
0, so trying to access it caused a crash.